Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1447456

Re: [PATCH v11 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl

Show all headers | View raw

On Wednesday, July 20, 2016 1:31:48 PM CEST Scott Wood wrote:
> On Wed, 2016-07-20 at 13:24 +0200, Arnd Bergmann wrote:
> > On Saturday, July 16, 2016 9:50:21 PM CEST Scott Wood wrote:
> > > 
> > > From: yangbo lu <yangbo.lu@nxp.com>
> > > 
> > > Move mpc85xx.h to include/linux/fsl and rename it to svr.h as a common
> > > header file.  This SVR numberspace is used on some ARM chips as well as
> > > PPC, and even to check for a PPC SVR multi-arch drivers would otherwise
> > > need to ifdef the header inclusion and all references to the SVR symbols.
> > > 
> > > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
> > > Acked-by: Wolfram Sang <wsa@the-dreams.de>
> > > Acked-by: Stephen Boyd <sboyd@codeaurora.org>
> > > Acked-by: Joerg Roedel <jroedel@suse.de>
> > > [scottwood: update description]
> > > Signed-off-by: Scott Wood <oss@buserror.net>
> > > 
> > As discussed before, please don't introduce yet another vendor specific
> > way to match a SoC ID from a device driver.
> > 
> > I've posted a patch for an extension to the soc_device infrastructure
> > to allow comparing the running SoC to a table of devices, use that
> > instead.
> 
> As I asked before, in which relevant maintainership capacity are you NACKing
> this?

I don't know why that's important, but I suggested the creation of
drivers/soc/ as a place to have a more general place for platform
specific drivers as part of being maintainer for arm-soc, and
almost all changes to drivers/soc go through our tree.

Olof does about half the merges, but I do the majority of the reviews
for drivers/soc patches. See also

git log --graph --format="%an %s" --merges drivers/soc/ 

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v11 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl Scott Wood <oss@buserror.net> - 2016-07-17 05:00 +0200
  Re: [PATCH v11 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl Arnd Bergmann <arnd@arndb.de> - 2016-07-20 13:30 +0200
    Re: [PATCH v11 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl Scott Wood <oss@buserror.net> - 2016-07-20 20:40 +0200
      Re: [PATCH v11 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl Arnd Bergmann <arnd@arndb.de> - 2016-07-20 22:40 +0200
      Re: [PATCH v11 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl Michael Ellerman <mpe@ellerman.id.au> - 2016-07-21 12:30 +0200
        Re: [PATCH v11 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl Scott Wood <oss@buserror.net> - 2016-07-21 18:50 +0200
          Re: [PATCH v11 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl Arnd Bergmann <arnd@arndb.de> - 2016-07-21 20:40 +0200
          RE: [PATCH v11 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl Yangbo Lu <yangbo.lu@nxp.com> - 2016-07-25 10:50 +0200

csiph-web