Re: [PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

Path	csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac
Date	Wed, 20 Jul 2016 21:20:02 +0200
Message-ID	<rX5ce-5ro-11@gated-at.bofh.it> (permalink)
References	<rWUJP-7jB-7@gated-at.bofh.it> <rWUJQ-7jB-29@gated-at.bofh.it>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=a105kaiAlxzwYzfkl2GoaDVAOj/fVHAGwn03AFrHVoE=; b=Sez2iJu7v5nuThJOg/MRybauZvPKWPUp2QOpL9htPj6YbO6Ym7SRZkvzZOr4WTsjTi Ugu9DFDDfj9DVFEM3nwenL2mSca4OdjS66KA//oSsNcyYY+x40YgW75k5IVd9CX9A//c T/Yjmpm+yMu+/9mZalECWjCbxZ9T86mYbdYKRMbLwM00j92C8r+/NLNjggaXVlulYMoo UezlwRqLgDhk6Da2VA5Ch0b4BvZDZJPOMmlL4ex3iTdG+hhWLR5L/hprar6wv6Imr09x ZhAdvXafhi84LKSb6lyVH5Wu8DfOlQ0bu5/l4nqiFym4Ewrk0QbrTODYkRYWvfTdDlhR ky8A==
X-Gm-Message-State	ALyK8tK16S7SrjqzGiOmPdyJBu63p/YkXNT5snpC+NkJ9AXVOUNVSqGD0MYsrnHCx6BiTQ==
X-Received	by 10.157.48.49 with SMTP id d46mr23936699otc.91.1469042134387; Wed, 20 Jul 2016 12:15:34 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	58
Organization	linux.* mail to news gateway
X-Original-Cc	mark.rutland@arm.com, maxime.ripard@free-electrons.com, wens@csie.org, linux@armlinux.org.uk, davem@davemloft.net, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
X-Original-Date	Wed, 20 Jul 2016 14:15:33 -0500
X-Original-Message-ID	<20160720191533.GA12875@rob-hp-laptop>
X-Original-References	<1469001800-11615-1-git-send-email-clabbe.montjoie@gmail.com> <1469001800-11615-4-git-send-email-clabbe.montjoie@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1447407

Show key headers only | View raw

On Wed, Jul 20, 2016 at 10:03:18AM +0200, LABBE Corentin wrote:
> This patch adds documentation for Device-Tree bindings for the
> Allwinner sun8i-emac driver.
> 
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
> ---
>  .../bindings/net/allwinner,sun8i-emac.txt          | 65 ++++++++++++++++++++++
>  1 file changed, 65 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt
> 
> diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt b/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt
> new file mode 100644
> index 0000000..4bf4e53
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt
> @@ -0,0 +1,65 @@
> +* Allwinner sun8i EMAC ethernet controller
> +
> +Required properties:
> +- compatible: "allwinner,sun8i-a83t-emac", "allwinner,sun8i-h3-emac",
> +		or "allwinner,sun50i-a64-emac"

List one per line.

> +- reg: address and length of the register sets for the device.
> +- reg-names: should be "emac" and "syscon", matching the register sets
> +- interrupts: interrupt for the device
> +- clocks: A phandle to the reference clock for this device
> +- clock-names: should be "ahb"
> +- resets: A phandle to the reset control for this device
> +- reset-names: should be "ahb"
> +- phy-mode: See ethernet.txt
> +- phy or phy-handle: See ethernet.txt
> +- #address-cells: shall be 1
> +- #size-cells: shall be 0
> +
> +"allwinner,sun8i-h3-emac" also requires:
> +- clocks: an extra phandle to the reference clock for the EPHY
> +- clock-names: an extra "ephy" entry matching the clocks property
> +- resets: an extra phandle to the reset control for the EPHY
> +- resets-names: an extra "ephy" entry matching the resets property
> +
> +See ethernet.txt in the same directory for generic bindings for ethernet
> +controllers.
> +
> +The device node referenced by "phy" or "phy-handle" should be a child node
> +of this node. See phy.txt for the generic PHY bindings.
> +
> +Optional properties:
> +- phy-supply: phandle to a regulator if the PHY needs one
> +- phy-io-supply: phandle to a regulator if the PHY needs a another one for I/O.
> +		 This is sometimes found with RGMII PHYs, which use a second
> +		 regulator for the lower I/O voltage.

I previously said these should go in the phy node, and you said you 
would remove them.

Rob

Thread

[PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-07-20 10:10 +0200
  Re: [PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for  Allwinner sun8i-emac Rob Herring <robh@kernel.org> - 2016-07-20 21:20 +0200
  Re: [PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for  Allwinner sun8i-emac Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-07-21 10:00 +0200

csiph-web