Re: [PATCH] GPU-DRM-sun4i: Delete an unnecessary check before drm_fbdev_cma_hotplug_event()

From	Daniel Vetter <daniel@ffwll.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH] GPU-DRM-sun4i: Delete an unnecessary check before drm_fbdev_cma_hotplug_event()
Date	2016-07-20 19:50 +0200
Message-ID	<rX3N8-4tM-11@gated-at.bofh.it> (permalink)
References	(5 earlier) <mSsDN-4wa-61@gated-at.bofh.it> <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <rX2R4-3Qq-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 20, 2016 at 06:40:49PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 20 Jul 2016 18:32:34 +0200
> 
> The drm_fbdev_cma_hotplug_event() function tests whether its argument
> is NULL and then returns immediately.
> Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Applied to drm-misc, thanks.
-Daniel

> ---
>  drivers/gpu/drm/sun4i/sun4i_framebuffer.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/sun4i/sun4i_framebuffer.c b/drivers/gpu/drm/sun4i/sun4i_framebuffer.c
> index a0b30c2..70688fe 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_framebuffer.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_framebuffer.c
> @@ -20,8 +20,7 @@ static void sun4i_de_output_poll_changed(struct drm_device *drm)
>  {
>  	struct sun4i_drv *drv = drm->dev_private;
>  
> -	if (drv->fbdev)
> -		drm_fbdev_cma_hotplug_event(drv->fbdev);
> +	drm_fbdev_cma_hotplug_event(drv->fbdev);
>  }
>  
>  static const struct drm_mode_config_funcs sun4i_de_mode_config_funcs = {
> -- 
> 2.9.2
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] GPU-DRM-sun4i: Delete an unnecessary check before  drm_fbdev_cma_hotplug_event() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-20 18:50 +0200
  Re: [PATCH] GPU-DRM-sun4i: Delete an unnecessary check before  drm_fbdev_cma_hotplug_event() Daniel Vetter <daniel@ffwll.ch> - 2016-07-20 19:50 +0200

csiph-web