Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1447335
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2] [media] vb2: include lengths in dmabuf qbuf debug message |
| Date | 2016-07-20 18:10 +0200 |
| Message-ID | <rX2en-3Bs-37@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
If the VIDIOC_QBUF ioctl fails due a wrong dmabuf length, it's
useful to get the invalid and minimum lengths as a debug info.
Before this patch:
vb2-core: __qbuf_dmabuf: invalid dmabuf length for plane 1
After this patch:
vb2-core: __qbuf_dmabuf: invalid dmabuf length 221248 for plane 1, minimum length 410880
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
Changes in v2:
- Use %u instead of %d (Sakari Ailus)
- Include min_length (Sakari Ailus)
drivers/media/v4l2-core/videobuf2-core.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
index b6fbc04f9699..bbba50d6e1ad 100644
--- a/drivers/media/v4l2-core/videobuf2-core.c
+++ b/drivers/media/v4l2-core/videobuf2-core.c
@@ -1227,8 +1227,10 @@ static int __qbuf_dmabuf(struct vb2_buffer *vb, const void *pb)
planes[plane].length = dbuf->size;
if (planes[plane].length < vb->planes[plane].min_length) {
- dprintk(1, "invalid dmabuf length for plane %d\n",
- plane);
+ dprintk(1, "invalid dmabuf length %u for plane %d, "
+ "minimum length %u\n",
+ planes[plane].length, plane,
+ vb->planes[plane].min_length);
dma_buf_put(dbuf);
ret = -EINVAL;
goto err;
--
2.5.5
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH v2] [media] vb2: include lengths in dmabuf qbuf debug message Javier Martinez Canillas <javier@osg.samsung.com> - 2016-07-20 18:10 +0200
Re: [PATCH v2] [media] vb2: include lengths in dmabuf qbuf debug message Sakari Ailus <sakari.ailus@iki.fi> - 2016-07-20 22:00 +0200
Re: [PATCH v2] [media] vb2: include lengths in dmabuf qbuf debug message Javier Martinez Canillas <javier@osg.samsung.com> - 2016-07-21 01:00 +0200
Re: [PATCH v2] [media] vb2: include lengths in dmabuf qbuf debug message Sakari Ailus <sakari.ailus@iki.fi> - 2016-07-21 01:10 +0200
Re: [PATCH v2] [media] vb2: include lengths in dmabuf qbuf debug message Javier Martinez Canillas <javier@osg.samsung.com> - 2016-07-21 01:30 +0200
csiph-web