[PATCH] drm/atomic: Delete an unnecessary check before drm_property_unreference_blob()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH] drm/atomic: Delete an unnecessary check before drm_property_unreference_blob()
Date	2016-07-20 18:10 +0200
Message-ID	<rX2em-3Bs-31@gated-at.bofh.it> (permalink)
References	(6 earlier) <pIYoG-7bN-11@gated-at.bofh.it> <pJ8xI-4O7-11@gated-at.bofh.it> <pJ8xI-4O7-9@gated-at.bofh.it> <qrNdM-3Ni-13@gated-at.bofh.it> <qvsDL-8kq-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 20 Jul 2016 17:54:32 +0200

The drm_property_unreference_blob() function tests whether its argument
is NULL and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/gpu/drm/drm_atomic.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index 3cee084..8d2f111 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b/drivers/gpu/drm/drm_atomic.c
@@ -404,8 +404,7 @@ drm_atomic_replace_property_blob(struct drm_property_blob **blob,
 	if (old_blob == new_blob)
 		return;
 
-	if (old_blob)
-		drm_property_unreference_blob(old_blob);
+	drm_property_unreference_blob(old_blob);
 	if (new_blob)
 		drm_property_reference_blob(new_blob);
 	*blob = new_blob;
-- 
2.9.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/atomic: Delete an unnecessary check before  drm_property_unreference_blob() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-20 18:10 +0200
  Re: [PATCH] drm/atomic: Delete an unnecessary check before drm_property_unreference_blob() Sean Paul <seanpaul@chromium.org> - 2016-07-20 19:40 +0200

csiph-web