Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1447319
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 9/9] staging: ks7010: Delete three unnecessary variable initialisations |
| Date | 2016-07-20 18:00 +0200 |
| Message-ID | <rX24F-3jb-13@gated-at.bofh.it> (permalink) |
| References | (5 earlier) <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <rVYFQ-430-11@gated-at.bofh.it> <rVZ8R-4co-7@gated-at.bofh.it> <rVZsd-4jy-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Sun, Jul 17, 2016 at 08:51:39PM +0200, Julia Lawall wrote:
>
>
> On Sun, 17 Jul 2016, SF Markus Elfring wrote:
>
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Sun, 17 Jul 2016 19:40:47 +0200
> >
> > Three variables will be set to an appropriate value a bit later.
> > Thus omit the explicit initialisation at the beginning.
> >
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> > ---
> > drivers/staging/ks7010/ks7010_sdio.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> > index e06bc3c..3c62c57 100644
> > --- a/drivers/staging/ks7010/ks7010_sdio.c
> > +++ b/drivers/staging/ks7010/ks7010_sdio.c
> > @@ -323,14 +323,14 @@ static void tx_device_task(void *dev)
> > {
> > struct ks_wlan_private *priv = (struct ks_wlan_private *)dev;
> > struct tx_device_buffer *sp;
> > - int rc = 0;
> >
> > DPRINTK(4, "\n");
> > if (cnt_txqbody(priv) > 0
> > && atomic_read(&priv->psstatus.status) != PS_SNOOZE) {
> > sp = &priv->tx_dev.tx_dev_buff[priv->tx_dev.qhead];
> > if (priv->dev_state >= DEVICE_STATE_BOOT) {
> > - rc = write_to_device(priv, sp->sendp, sp->size);
> > + int rc = write_to_device(priv, sp->sendp, sp->size);
>
> This does not look appealing to me, neither the declaration in the middle
> of the function, nor the intiialization to the result of a complex
> expression, nor the separation of the call and the error checking code by
> a blank line. There is nothing wrong with having the rc variable be
> declared at the the top of the function, in its normal place.
+1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/9] staging: ks7010: Fine-tuning for a SDIO card driver SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-17 20:10 +0200
[PATCH 2/9] staging: ks7010: Delete unnecessary assignments for buffer variables SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-17 20:20 +0200
Re: [PATCH 2/9] staging: ks7010: Delete unnecessary assignments for buffer variables Wolfram Sang <wsa@the-dreams.de> - 2016-07-20 17:50 +0200
[PATCH 1/9] staging: ks7010: Delete unnecessary checks before the function call "kfree" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-17 20:20 +0200
Re: [PATCH 1/9] staging: ks7010: Delete unnecessary checks before the function call "kfree" Wolfram Sang <wsa@the-dreams.de> - 2016-07-20 17:50 +0200
[PATCH 3/9] staging: ks7010: Return directly after a failed kmalloc() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-17 20:20 +0200
Re: [PATCH 3/9] staging: ks7010: Return directly after a failed kmalloc() Julia Lawall <julia.lawall@lip6.fr> - 2016-07-17 21:00 +0200
Re: [PATCH 3/9] staging: ks7010: Return directly after a failed kmalloc() Wolfram Sang <wsa@the-dreams.de> - 2016-07-20 17:50 +0200
Re: [PATCH 3/9] staging: ks7010: Return directly after a failed kmalloc() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-20 20:50 +0200
Re: [PATCH 3/9] staging: ks7010: Return directly after a failed kmalloc() Wolfram Sang <wsa@the-dreams.de> - 2016-07-21 08:30 +0200
Re: staging: ks7010: Return directly after a failed kmalloc() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-22 09:40 +0200
Re: staging: ks7010: Return directly after a failed kmalloc() Wolfram Sang <wsa@the-dreams.de> - 2016-07-22 09:50 +0200
[PATCH 7/9] staging: ks7010: Replace three printk() calls by pr_err() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-17 20:30 +0200
Re: [PATCH 7/9] staging: ks7010: Replace three printk() calls by pr_err() Joe Perches <joe@perches.com> - 2016-07-17 22:30 +0200
Re: [PATCH 7/9] staging: ks7010: Replace three printk() calls by pr_err() Wolfram Sang <wsa@the-dreams.de> - 2016-07-20 18:00 +0200
[PATCH 5/9] staging: ks7010: Delete unnecessary uses of the variable "retval" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-17 20:30 +0200
Re: [PATCH 5/9] staging: ks7010: Delete unnecessary uses of the variable "retval" Julia Lawall <julia.lawall@lip6.fr> - 2016-07-17 21:00 +0200
Re: [PATCH 5/9] staging: ks7010: Delete unnecessary uses of the variable "retval" Wolfram Sang <wsa@the-dreams.de> - 2016-07-20 18:00 +0200
Re: [PATCH 5/9] staging: ks7010: Delete unnecessary uses of the variable "retval" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-20 20:50 +0200
Re: [PATCH 5/9] staging: ks7010: Delete unnecessary uses of the variable "retval" Wolfram Sang <wsa@the-dreams.de> - 2016-07-21 08:30 +0200
Re: [PATCH 5/9] staging: ks7010: Delete unnecessary uses of the variable "retval" Wolfram Sang <wsa@the-dreams.de> - 2016-07-21 09:30 +0200
Re: [PATCH 5/9] staging: ks7010: Delete unnecessary uses of the variable "retval" Julia Lawall <julia.lawall@lip6.fr> - 2016-07-21 09:30 +0200
Re: staging: ks7010: Delete unnecessary uses of the variable "retval" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-21 14:50 +0200
Re: staging: ks7010: Delete unnecessary uses of the variable "retval" Julia Lawall <julia.lawall@lip6.fr> - 2016-07-21 15:00 +0200
Re: staging: ks7010: Delete unnecessary uses of the variable "retval" Wolfram Sang <wsa@the-dreams.de> - 2016-07-21 18:40 +0200
Re: staging: ks7010: Delete unnecessary uses of the variable "retval" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-21 15:40 +0200
Re: staging: ks7010: Delete unnecessary uses of the variable "retval" Wolfram Sang <wsa@the-dreams.de> - 2016-07-21 18:40 +0200
Re: staging: ks7010: Delete unnecessary uses of the variable "retval" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-21 23:30 +0200
Re: staging: ks7010: Delete unnecessary uses of the variable "retval" Wolfram Sang <wsa@the-dreams.de> - 2016-07-22 08:00 +0200
[PATCH 8/9] staging: ks7010: Delete a variable in write_to_device() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-17 20:30 +0200
Re: [PATCH 8/9] staging: ks7010: Delete a variable in write_to_device() Wolfram Sang <wsa@the-dreams.de> - 2016-07-20 18:00 +0200
[PATCH 4/9] staging: ks7010: Rename jump labels SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-17 20:30 +0200
Re: [PATCH 4/9] staging: ks7010: Rename jump labels Wolfram Sang <wsa@the-dreams.de> - 2016-07-20 18:00 +0200
Re: staging: ks7010: Rename jump labels SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-20 20:30 +0200
Re: staging: ks7010: Rename jump labels Jean Delvare <jdelvare@suse.de> - 2016-07-20 23:20 +0200
Re: staging: ks7010: Rename jump labels Wolfram Sang <wsa@the-dreams.de> - 2016-07-21 08:30 +0200
Re: staging: ks7010: Rename jump labels "SF Markus Elfring" <elfring@users.sourceforge.net> - 2016-07-21 10:00 +0200
Re: staging: ks7010: Rename jump labels Jean Delvare <jdelvare@suse.de> - 2016-07-25 14:40 +0200
Re: staging: ks7010: Rename jump labels SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-21 17:40 +0200
Re: staging: ks7010: Rename jump labels Jean Delvare <jdelvare@suse.de> - 2016-07-21 21:20 +0200
Re: staging: ks7010: Rename jump labels SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-21 22:30 +0200
Re: staging: ks7010: Rename jump labels Jean Delvare <jdelvare@suse.de> - 2016-07-25 14:40 +0200
Re: staging: ks7010: Rename jump labels SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-25 18:20 +0200
Re: staging: ks7010: Rename jump labels Jean Delvare <jdelvare@suse.de> - 2016-07-25 23:10 +0200
[PATCH 6/9] staging: ks7010: Delete unnecessary braces SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-17 20:30 +0200
Re: [PATCH 6/9] staging: ks7010: Delete unnecessary braces Julia Lawall <julia.lawall@lip6.fr> - 2016-07-17 21:00 +0200
Re: [PATCH 6/9] staging: ks7010: Delete unnecessary braces Wolfram Sang <wsa@the-dreams.de> - 2016-07-20 18:00 +0200
[PATCH 9/9] staging: ks7010: Delete three unnecessary variable initialisations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-17 20:40 +0200
Re: [PATCH 9/9] staging: ks7010: Delete three unnecessary variable initialisations Julia Lawall <julia.lawall@lip6.fr> - 2016-07-17 21:00 +0200
Re: [PATCH 9/9] staging: ks7010: Delete three unnecessary variable initialisations Wolfram Sang <wsa@the-dreams.de> - 2016-07-20 18:00 +0200
Re: [PATCH 9/9] staging: ks7010: Delete three unnecessary variable initialisations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-21 15:50 +0200
Re: [PATCH 9/9] staging: ks7010: Delete three unnecessary variable initialisations Julia Lawall <julia.lawall@lip6.fr> - 2016-07-21 16:00 +0200
Re: staging: ks7010: Delete three unnecessary variable initialisations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-21 16:20 +0200
csiph-web