Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1447277

Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting

From Jonathan Cameron <jic23@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting
Date 2016-07-20 17:10 +0200
Message-ID <rX1ih-33s-3@gated-at.bofh.it> (permalink)
References <rVnwB-6tq-3@gated-at.bofh.it> <rWcIN-4ho-13@gated-at.bofh.it> <rWvV8-8mi-17@gated-at.bofh.it> <rWxtU-129-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 19/07/16 08:13, Wolfram Sang wrote:
> On Mon, Jul 18, 2016 at 02:30:46PM +0100, Jonathan Cameron wrote:
>> On 18/07/16 09:50, Laxman Dewangan wrote:
>>>
>>> On Saturday 16 July 2016 07:58 AM, Alison Schofield wrote:
>>>> I2C_CLASS_HWMON is for a hardware monitoring chip wanting
>>>> auto-detection.  IIO drivers don't typically use .class.
>>>> Remove it.
>>>>
>>>> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
>>>> Cc: Daniel Baluta <daniel.baluta@gmail.com>
>>>>
>>>
>>> Agree.
>>> Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
>> Any resulting ABI change from dropping it?
> 
> What do you mean with ABI? This is only relevant for "automatic"
> instantiation.
Cool, I was just being paranoid and didn't have time to check!

Thanks,

Jonathan
> From me:
> 
> Acked-by: Wolfram Sang <wsa@the-dreams.de>
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON  .class setting Alison Schofield <amsfield22@gmail.com> - 2016-07-16 04:30 +0200
  Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON  .class setting Laxman Dewangan <ldewangan@nvidia.com> - 2016-07-18 11:10 +0200
    Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON  .class setting Jonathan Cameron <jic23@kernel.org> - 2016-07-19 07:40 +0200
      Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON  .class setting Wolfram Sang <wsa@the-dreams.de> - 2016-07-19 09:20 +0200
        Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON  .class setting Jonathan Cameron <jic23@kernel.org> - 2016-07-20 17:10 +0200
          Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON  .class setting Jonathan Cameron <jic23@kernel.org> - 2016-07-24 13:40 +0200

csiph-web