Re: [PATCH]time: Optimize nohz idle enter

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH]time: Optimize nohz idle enter
Date	2016-07-19 11:00 +0200
Message-ID	<rWz2G-1PI-15@gated-at.bofh.it> (permalink)
References	<rWz2G-1PI-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 14 Jul 2016, Gaurav Jindal (Gaurav Jindal) wrote:
> 
> tick_nohz_start_idle is called before checking the condition if the idle tick
> can be stopped. In case when can_stop_idle_tick returns 0, the function called
> is of no use thus a extra call doing nothing.
> 
> Shifting calling of function tick_nohz_start_idle inside the if condition makes
> sure that corresponding operations are done only if idle tick can be actually
> stopped. Observance for 1 minute on arm64 architecture shows that shifting code
> can prevent 1.5% of extra calls thus optimizing the idle call sequence.

Nice.

> Signed-off-by: gaurav jindal<gaurav.jindal@spreadtrum.com>
> Signed-off-by: sanjeev yadav<sanjeev.yadav@spreadtrum.com>

This SOB chain is wrong. Sanjeev did not send the patch and is not the
author. Please clarify.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH]time: Optimize nohz idle enter  Thomas Gleixner <tglx@linutronix.de> - 2016-07-19 11:00 +0200
  Re: [PATCH]time: Optimize nohz idle enter "Gaurav Jindal (Gaurav Jindal)" <Gaurav.Jindal@spreadtrum.com> - 2016-07-19 12:10 +0200
    Re: [PATCH]time: Optimize nohz idle enter Thomas Gleixner <tglx@linutronix.de> - 2016-07-19 12:50 +0200

csiph-web