Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1446225

[PATCH 2/2] [media] cec: add RC_CORE dependency

Show all headers | View raw

We cannot build the cec driver when the RC core is a module
and cec is built-in:

drivers/staging/built-in.o: In function `cec_allocate_adapter':
:(.text+0x134): undefined reference to `rc_allocate_device'
drivers/staging/built-in.o: In function `cec_register_adapter':
:(.text+0x304): undefined reference to `rc_register_device'

This adds an explicit dependency to avoid this case. We still
allow building when CONFIG_RC_CORE is disabled completely,
as the driver has checks for this case itself.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
I originally submitted this on June 29, but it may have gotten
lost as out of the three patch series, one patch got replaced
and another patch got applied, but nothing happened on this one.
---
 drivers/staging/media/cec/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/media/cec/Kconfig b/drivers/staging/media/cec/Kconfig
index 21457a1f6c9f..c623bd32a5b8 100644
--- a/drivers/staging/media/cec/Kconfig
+++ b/drivers/staging/media/cec/Kconfig
@@ -1,6 +1,7 @@
 config MEDIA_CEC
 	bool "CEC API (EXPERIMENTAL)"
 	depends on MEDIA_SUPPORT
+	depends on RC_CORE || !RC_CORE
 	select MEDIA_CEC_EDID
 	---help---
 	  Enable the CEC API.
-- 
2.9.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] [media] cec: add RC_CORE dependency Arnd Bergmann <arnd@arndb.de> - 2016-07-19 10:20 +0200
  Re: [PATCH 2/2] [media] cec: add RC_CORE dependency Arnd Bergmann <arnd@arndb.de> - 2016-07-19 10:40 +0200
  Re: [PATCH 2/2] [media] cec: add RC_CORE dependency Hans Verkuil <hverkuil@xs4all.nl> - 2016-07-19 10:40 +0200

csiph-web