Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1446145

Re: linux-next: build failure after merge of the wireless-drivers-next tree

Show all headers | View raw

On 19 July 2016 at 09:09, Kalle Valo <kvalo@codeaurora.org> wrote:
> Rafał Miłecki <zajec5@gmail.com> writes:
>
>> On 19 July 2016 at 08:30, Kalle Valo <kvalo@codeaurora.org> wrote:
>>> Stephen Rothwell <sfr@canb.auug.org.au> writes:
>>>
>>>> After merging the wireless-drivers-next tree, today's linux-next build
>>>> (powerpc allyesconfig) failed like this:
>>>>
>>>> drivers/mtd/devices/bcm47xxsflash.c: In function 'bcm47xxsflash_bcma_probe':
>>>> drivers/mtd/devices/bcm47xxsflash.c:299:17: error: implicit declaration of function 'ioremap_cache' [-Werror=implicit-function-declaration]
>>>>   b47s->window = ioremap_cache(res->start, resource_size(res));
>>>>                  ^
>>>> drivers/mtd/devices/bcm47xxsflash.c:299:15: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>>>   b47s->window = ioremap_cache(res->start, resource_size(res));
>>>>                ^
>>>>
>>>> Caused by commit
>>>>
>>>>   57d8f7dd2132 ("bcma: allow enabling serial flash support on non-MIPS SoCs")
>>>>
>>>> I have reverted that commit for today.
>>>
>>> Thanks, kbuild bot also notified about this.
>>>
>>> Rafał, as the merge window is getting really close I would like to
>>> revert this for now and we can reapply it once we the problem is fully
>>> solved. And we can use my pending branch for build testing the patch
>>> with kbuild bot. What do you think?
>>
>> The simplest fix sounds pretty much as simple as the revert.
>
> The problem is that I don't have much time, I need to send the pull
> request to Dave within next few days. The fix might create other
> problems so I'm not enthusiastic about iterating with this patch at the
> moment. I think it can wait for 4.9.

I sent a patch seconds ago, you may just take a look at it. If you
still prefer to revert my commit, go ahead.

-- 
Rafał

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

linux-next: build failure after merge of the wireless-drivers-next  tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-07-19 08:10 +0200
  Re: linux-next: build failure after merge of the wireless-drivers-next tree Kalle Valo <kvalo@codeaurora.org> - 2016-07-19 08:40 +0200
    Re: linux-next: build failure after merge of the wireless-drivers-next  tree Rafał Miłecki <zajec5@gmail.com> - 2016-07-19 09:00 +0200
      Re: linux-next: build failure after merge of the wireless-drivers-next tree Kalle Valo <kvalo@codeaurora.org> - 2016-07-19 09:10 +0200
        Re: linux-next: build failure after merge of the wireless-drivers-next  tree Rafał Miłecki <zajec5@gmail.com> - 2016-07-19 09:20 +0200
          Re: linux-next: build failure after merge of the wireless-drivers-next tree Kalle Valo <kvalo@codeaurora.org> - 2016-07-19 16:10 +0200
            Re: linux-next: build failure after merge of the  wireless-drivers-next tree Brian Norris <computersforpeace@gmail.com> - 2016-07-19 20:40 +0200
              Re: linux-next: build failure after merge of the  wireless-drivers-next tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-07-20 01:40 +0200
              Re: linux-next: build failure after merge of the wireless-drivers-next tree Kalle Valo <kvalo@codeaurora.org> - 2016-07-20 20:40 +0200

csiph-web