Re: [PATCH v3 1/4] lib/dlock-list: Distributed and lock-protected lists

From	Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/4] lib/dlock-list: Distributed and lock-protected lists
Date	2016-07-19 07:10 +0200
Message-ID	<rWvs5-8aD-1@gated-at.bofh.it> (permalink)
References	<rVfpn-1mA-3@gated-at.bofh.it> <rVfpo-1mA-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jul 15, 2016 at 01:39:40PM -0400, Waiman Long wrote:

> +struct dlock_list_head_percpu {
> +	struct list_head list;
> +	spinlock_t lock;
> +};

> +#define DLOCK_LIST_HEAD_PERCPU_INIT(name)			\
> +	{							\
> +		.list.prev = &name.list,			\
> +		.list.next = &name.list,			\
> +		.list.lock = __SPIN_LOCK_UNLOCKED(name),	\

What's .list.lock and how does that even compile?

> +extern bool dlock_list_next(struct dlock_list_head *dlist,
> +			    struct dlock_list_iter *iter);

Ugh...  Why not dlist_for_each_entry(), seeing that all users end up with
the same boilerplate?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/4] vfs: Use dlock list for SB's s_inodes list Waiman Long <Waiman.Long@hpe.com> - 2016-07-15 19:50 +0200
  [PATCH v3 1/4] lib/dlock-list: Distributed and lock-protected lists Waiman Long <Waiman.Long@hpe.com> - 2016-07-15 19:50 +0200
    Re: [PATCH v3 1/4] lib/dlock-list: Distributed and lock-protected  lists Tejun Heo <tj@kernel.org> - 2016-07-19 01:40 +0200
      Re: [PATCH v3 1/4] lib/dlock-list: Distributed and lock-protected  lists Tejun Heo <tj@kernel.org> - 2016-07-19 21:30 +0200
      Re: [PATCH v3 1/4] lib/dlock-list: Distributed and lock-protected  lists Christoph Lameter <cl@linux.com> - 2016-07-21 02:50 +0200
        Re: [PATCH v3 1/4] lib/dlock-list: Distributed and lock-protected  lists Dave Chinner <david@fromorbit.com> - 2016-07-21 03:50 +0200
    Re: [PATCH v3 1/4] lib/dlock-list: Distributed and lock-protected  lists Al Viro <viro@ZenIV.linux.org.uk> - 2016-07-19 07:10 +0200

csiph-web