Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1446019

Re: [PATCH 3/3] f2fs: support clone_file_range

Show all headers | View raw

On Mon, Jul 18, 2016 at 08:47:36PM -0700, Christoph Hellwig wrote:
> On Sat, Jul 16, 2016 at 11:24:27PM -0700, Jaegeuk Kim wrote:
> > This patch implements clone_file_range in f2fs.
> 
> [...]
> 
> > +int f2fs_clone_file_range(struct file *file_in, loff_t pos_in,
> > +		struct file *file_out, loff_t pos_out, u64 len)
> > +{
> > +	return f2fs_clone_files(file_in, pos_in, file_out, pos_out, len);
> > +}
> > +
> 
> Falling back from copy to clone should be done in the VFS.  I look into
> implementing the fallback, and the code is trivial, but we don't seem
> to have any useful coverage for copy_file_range yet, so I didn't dare
> to add it yet.  How did you test copy and clone in f2fs?  And how did
> you handle the difference in corner cases (e.g. the lacking 0 special
> case in copy)?

Frankly speaking, I confused the behaviors without being aware of corner cases.
And thus, I dropped the patches already. Instead, I realized that what I did
was moving a range of blocks from one file to another file. So, I've been
testing a new ioctl, F2FS_IOC_MOVE_RANGE.
In terms of coverage, I just did some unit tests only.

Thanks,

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] f2fs: avoid memory allocation failure due to a long length Jaegeuk Kim <jaegeuk@kernel.org> - 2016-07-17 08:30 +0200
  [PATCH 3/3] f2fs: support clone_file_range Jaegeuk Kim <jaegeuk@kernel.org> - 2016-07-17 08:30 +0200
    Re: [PATCH 3/3] f2fs: support clone_file_range Christoph Hellwig <hch@infradead.org> - 2016-07-19 05:50 +0200
      Re: [PATCH 3/3] f2fs: support clone_file_range Jaegeuk Kim <jaegeuk@kernel.org> - 2016-07-19 06:50 +0200

csiph-web