Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1446015

Re: [PATCH v1] ESIA : Dummy eisa_driver_register should return error code

From Christoph Hellwig <hch@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH v1] ESIA : Dummy eisa_driver_register should return error code
Date 2016-07-19 06:40 +0200
Message-ID <rWuZ3-7HB-1@gated-at.bofh.it> (permalink)
References <rWlM6-1sH-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Jul 19, 2016 at 12:15:01AM +0530, Arvind Yadav wrote:
> The inline eisa_driver_register stub simply allows compilation on
> systems with CONFIG_EISA disabled. the dummy eisa_driver_register
> does not register an *_eisa_driver at all. The inline
> eisa_driver_register should return to indicate lack of support
> when attempting to register an *_eisa_driver on such a system with
> CONFIG_EISA disabled.

Why?  The idea is that you can simply leave the stub in if registering
say PCI / EISA.  With your change such a driver will fail to load even
if it could serve PCI device in a !CONFIG_EISA config, which is the
behavior we want.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1] ESIA : Dummy eisa_driver_register should return error code Arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-07-18 20:50 +0200
  Re: [PATCH v1] ESIA : Dummy eisa_driver_register should return error  code Christoph Hellwig <hch@infradead.org> - 2016-07-19 06:40 +0200
    Re: [PATCH v1] ESIA : Dummy eisa_driver_register should return error  code arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-07-19 18:00 +0200

csiph-web