Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1445992

[PATCH] mm/vmscan: remove pglist_data->inactive_ratio

Show all headers | View raw

In patch [1], the inactive_ratio is now automatically calculated
in inactive_list_is_low(). So there is no need to keep inactive_ratio
in pglist_data, and shown in zoneinfo.

[1] mm: vmscan: reduce size of inactive file list

Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
---
 include/linux/mmzone.h | 6 ------
 mm/vmscan.c            | 2 +-
 mm/vmstat.c            | 6 ++----
 3 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index a3b7f45..b3ade54 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -700,12 +700,6 @@ typedef struct pglist_data {
 	/* Fields commonly accessed by the page reclaim scanner */
 	struct lruvec		lruvec;
 
-	/*
-	 * The target ratio of ACTIVE_ANON to INACTIVE_ANON pages on
-	 * this node's LRU.  Maintained by the pageout code.
-	 */
-	unsigned int inactive_ratio;
-
 	unsigned long		flags;
 
 	ZONE_PADDING(_pad2_)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 429bf3a..3c1de58 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1915,7 +1915,7 @@ static void shrink_active_list(unsigned long nr_to_scan,
  * page has a chance to be referenced again before it is reclaimed.
  *
  * The inactive_ratio is the target ratio of ACTIVE to INACTIVE pages
- * on this LRU, maintained by the pageout code. A zone->inactive_ratio
+ * on this LRU, maintained by the pageout code. A inactive_ratio
  * of 3 means 3:1 or 25% of the pages are kept on the inactive list.
  *
  * total     target    max
diff --git a/mm/vmstat.c b/mm/vmstat.c
index 91ecca9..74a0eca 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -1491,11 +1491,9 @@ static void zoneinfo_show_print(struct seq_file *m, pg_data_t *pgdat,
 	}
 	seq_printf(m,
 		   "\n  node_unreclaimable:  %u"
-		   "\n  start_pfn:           %lu"
-		   "\n  node_inactive_ratio: %u",
+		   "\n  start_pfn:           %lu",
 		   !pgdat_reclaimable(zone->zone_pgdat),
-		   zone->zone_start_pfn,
-		   zone->zone_pgdat->inactive_ratio);
+		   zone->zone_start_pfn);
 	seq_putc(m, '\n');
 }
 
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm/vmscan: remove pglist_data->inactive_ratio Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-07-19 04:10 +0200
  Re: [PATCH] mm/vmscan: remove pglist_data->inactive_ratio Michal Hocko <mhocko@kernel.org> - 2016-07-19 09:40 +0200
    Re: [PATCH] mm/vmscan: remove pglist_data->inactive_ratio Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-07-21 10:40 +0200

csiph-web