Re: [mtd-next:master 30/33] drivers/mtd/spi-nor/cadence-quadspi.c:529:4: error: implicit declaration of function 'readsl'

From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [mtd-next:master 30/33] drivers/mtd/spi-nor/cadence-quadspi.c:529:4: error: implicit declaration of function 'readsl'
Date	2016-07-18 22:30 +0200
Message-ID	<rWnkS-2Af-3@gated-at.bofh.it> (permalink)
References	<rWnkS-2Af-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jul 19, 2016 at 03:43:17AM +0800, kbuild test robot wrote:
> tree:   git://git.infradead.org/linux-mtd-next.git master
> head:   f78921b9020c510ed222a6c2402e2aa126432415
> commit: 140623410536905fa6ab737b625decfde6c64a72 [30/33] mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller
> config: x86_64-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
> reproduce:
>         git checkout 140623410536905fa6ab737b625decfde6c64a72
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/mtd/spi-nor/cadence-quadspi.c: In function 'cqspi_indirect_read_execute':
> >> drivers/mtd/spi-nor/cadence-quadspi.c:529:4: error: implicit declaration of function 'readsl' [-Werror=implicit-function-declaration]
>        readsl(ahb_base, rxbuf, DIV_ROUND_UP(bytes_to_read, 4));
>        ^~~~~~
>    drivers/mtd/spi-nor/cadence-quadspi.c: In function 'cqspi_indirect_write_execute':
> >> drivers/mtd/spi-nor/cadence-quadspi.c:613:3: error: implicit declaration of function 'writesl' [-Werror=implicit-function-declaration]
>       writesl(cqspi->ahb_base, txbuf, DIV_ROUND_UP(write_bytes, 4));
>       ^~~~~~~
>    cc1: some warnings being treated as errors

Hmm, does x86 not define readsl()/writesl()? I can never tell what
accessors are supposed to be "standard" across architectures.

Either we need to drop the COMPILE_TEST or maybe make it (!X86 &&
COMPILE_TEST).

Brian

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [mtd-next:master 30/33]  drivers/mtd/spi-nor/cadence-quadspi.c:529:4: error: implicit declaration of  function 'readsl' Brian Norris <computersforpeace@gmail.com> - 2016-07-18 22:30 +0200
  Re: [mtd-next:master 30/33]  drivers/mtd/spi-nor/cadence-quadspi.c:529:4: error: implicit declaration of  function 'readsl' Stefan Roese <sr@denx.de> - 2016-07-19 08:10 +0200
    [PATCH] mtd: spi-nor: don't build Cadence QuadSPI on non-ARM Brian Norris <computersforpeace@gmail.com> - 2016-07-19 22:10 +0200
      Re: [PATCH] mtd: spi-nor: don't build Cadence QuadSPI on non-ARM Marek Vasut <marex@denx.de> - 2016-07-20 04:00 +0200
        Re: [PATCH] mtd: spi-nor: don't build Cadence QuadSPI on non-ARM Marek Vasut <marex@denx.de> - 2016-07-20 05:00 +0200
          Re: [PATCH] mtd: spi-nor: don't build Cadence QuadSPI on non-ARM Brian Norris <computersforpeace@gmail.com> - 2016-07-20 05:30 +0200
            Re: [PATCH] mtd: spi-nor: don't build Cadence QuadSPI on non-ARM Marek Vasut <marex@denx.de> - 2016-07-20 08:10 +0200
        Re: [PATCH] mtd: spi-nor: don't build Cadence QuadSPI on non-ARM Brian Norris <computersforpeace@gmail.com> - 2016-07-20 05:00 +0200

csiph-web