Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1445753

Re: [PATCH] irqchip: armada: avoid unused function warnings

Show all headers | View raw

+ Anna-Maria

Hey Arnd,

On Mon, Jul 18, 2016 at 06:03:21PM +0200, Arnd Bergmann wrote:
> When building with CONFIG_SMP disabled, we get some new harmless warnings:
> 
> drivers/irqchip/irq-armada-370-xp.c:356:12: error: 'mpic_cascaded_starting_cpu' defined but not used [-Werror=unused-function]
>  static int mpic_cascaded_starting_cpu(unsigned int cpu)
>             ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/irqchip/irq-armada-370-xp.c:349:12: error: 'armada_xp_mpic_starting_cpu' defined but not used [-Werror=unused-function]
>  static int armada_xp_mpic_starting_cpu(unsigned int cpu)
> 
> This moves the unused functions into the #ifdef, as they previously were.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: cb5ff2d245c1 ("irqchip/armada-370-xp: Convert to hotplug state machine")
> ---
>  drivers/irqchip/irq-armada-370-xp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Jason Cooper <jason@lakedaemon.net>

Anna-Maria, can you make sure this gets pulled in with the cpuhp
changes?  afaict, cb5ff2d245c1 is only in the tip/WIP.hotplug and
tip/master.

thx,

Jason.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] irqchip: armada: avoid unused function warnings Arnd Bergmann <arnd@arndb.de> - 2016-07-18 18:10 +0200
  Re: [PATCH] irqchip: armada: avoid unused function warnings Jason Cooper <jason@lakedaemon.net> - 2016-07-18 21:30 +0200
  [tip:smp/hotplug] irqchip/armada: Avoid unused function warnings tip-bot for Arnd Bergmann <tipbot@zytor.com> - 2016-07-19 09:50 +0200

csiph-web