Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1445783

Re: [PATCH v2 net-next v2 03/12] net: dsa: mv88e6xxx: extract device mapping

Show all headers | View raw

Hi Andrew,

Andrew Lunn <andrew@lunn.ch> writes:

>> +/* Indirect write to single pointer-data register with an Update bit */
>> +static int mv88e6xxx_update_write(struct mv88e6xxx_chip *chip,
>> +				  int addr, int reg, u16 update)
>
> Hi Vivien
>
> I don't think mv88e6xxx_update_read() makes any sense? Can we just
> infer write? Call it mv88e6xxx_update().

Yes it does, a read operation in such register consists of write+read
(first write the pointer to read, then read the actual value.)

>> +static int mv88e6xxx_g2_device_mapping_write(struct mv88e6xxx_chip *chip,
>> +					     int target, int port)
>> +{
>> +	u16 val = (target << 8) | (port & 0xf);
>> +
>> +	return mv88e6xxx_update_write(chip, REG_GLOBAL2, GLOBAL2_DEVICE_MAPPING,
>> +				      val);
>
> This would then all be on one line and look a better.

I plan to add more cleanup for register description later, such as
s/REG_GLOBAL2/ADDR_G2/ and s/GLOBAL2_/G2/. But that'll be a future patch.

Thanks,

        Vivien

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 net-next v2 00/12] net: dsa: mv88e6xxx: Global2 cleanup and STP Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-07-18 20:50 +0200
  [PATCH v2 net-next v2 03/12] net: dsa: mv88e6xxx: extract device mapping Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-07-18 20:50 +0200
    Re: [PATCH v2 net-next v2 03/12] net: dsa: mv88e6xxx: extract device  mapping Andrew Lunn <andrew@lunn.ch> - 2016-07-18 21:40 +0200
      Re: [PATCH v2 net-next v2 03/12] net: dsa: mv88e6xxx: extract device mapping Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-07-18 21:50 +0200
  [PATCH v2 net-next v2 01/12] net: dsa: mv88e6xxx: remove basic function flags Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-07-18 20:50 +0200
    Re: [PATCH v2 net-next v2 01/12] net: dsa: mv88e6xxx: remove basic  function flags Andrew Lunn <andrew@lunn.ch> - 2016-07-18 21:30 +0200
  [PATCH v2 net-next v2 09/12] net: dsa: mv88e6xxx: add cap for IRL Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-07-18 20:50 +0200
    Re: [PATCH v2 net-next v2 09/12] net: dsa: mv88e6xxx: add cap for IRL Andrew Lunn <andrew@lunn.ch> - 2016-07-18 21:50 +0200
  [PATCH v2 net-next v2 11/12] net: dsa: mv88e6xxx: add G1 helper for ageing time Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-07-18 20:50 +0200
  [PATCH v2 net-next v2 07/12] net: dsa: mv88e6xxx: add cap for PVT Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-07-18 20:50 +0200
    Re: [PATCH v2 net-next v2 07/12] net: dsa: mv88e6xxx: add cap for PVT Andrew Lunn <andrew@lunn.ch> - 2016-07-18 21:50 +0200
  [PATCH v2 net-next v2 10/12] net: dsa: support switchdev ageing time attr Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-07-18 20:50 +0200
  [PATCH v2 net-next v2 08/12] net: dsa: mv88e6xxx: add cap for Priority Override Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-07-18 21:00 +0200
    Re: [PATCH v2 net-next v2 08/12] net: dsa: mv88e6xxx: add cap for  Priority Override Andrew Lunn <andrew@lunn.ch> - 2016-07-18 21:50 +0200
  [PATCH v2 net-next v2 06/12] net: dsa: mv88e6xxx: rework Switch MAC setter Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-07-18 21:00 +0200
    Re: [PATCH v2 net-next v2 06/12] net: dsa: mv88e6xxx: rework Switch  MAC setter Andrew Lunn <andrew@lunn.ch> - 2016-07-18 21:50 +0200
  [PATCH v2 net-next v2 02/12] net: dsa: mv88e6xxx: split setup of Global 1 and 2 Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-07-18 21:00 +0200
    Re: [PATCH v2 net-next v2 02/12] net: dsa: mv88e6xxx: split setup of  Global 1 and 2 Andrew Lunn <andrew@lunn.ch> - 2016-07-18 21:30 +0200

csiph-web