Re: [PATCH] IPC-mqueue: Delete unnecessary checks before two function calls

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] IPC-mqueue: Delete unnecessary checks before two function calls
Date	2016-07-18 21:50 +0200
Message-ID	<rWmIa-233-13@gated-at.bofh.it> (permalink)
References	(13 earlier) <mSsDN-4wa-61@gated-at.bofh.it> <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <qrwcW-15C-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 5 Nov 2015 17:55:25 +0100
> 
> The functions iput() and unregister_sysctl_table() test whether their
> argument is NULL and then return immediately.
> Thus the tests around their calls are not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  ipc/mqueue.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/ipc/mqueue.c b/ipc/mqueue.c
> index 161a180..ade9dd8 100644
> --- a/ipc/mqueue.c
> +++ b/ipc/mqueue.c
> @@ -885,8 +885,7 @@ SYSCALL_DEFINE1(mq_unlink, const char __user *, u_name)
>  
>  out_unlock:
>  	mutex_unlock(&d_inode(mnt->mnt_root)->i_mutex);
> -	if (inode)
> -		iput(inode);
> +	iput(inode);
>  	mnt_drop_write(mnt);
>  out_name:
>  	putname(name);
> @@ -1460,8 +1459,7 @@ static int __init init_mqueue_fs(void)
>  out_filesystem:
>  	unregister_filesystem(&mqueue_fs_type);
>  out_sysctl:
> -	if (mq_sysctl_table)
> -		unregister_sysctl_table(mq_sysctl_table);
> +	unregister_sysctl_table(mq_sysctl_table);
>  	kmem_cache_destroy(mqueue_inode_cachep);
>  	return error;
>  }
> 

How do you think about to integrate this update suggestion
into another source code repository?

Regards,
Markus

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] IPC-mqueue: Delete unnecessary checks before two function  calls SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-18 21:50 +0200

csiph-web