Re: [PATCH 3/3] mac80211: mesh: fixed HT ies in beacon template

From	Johannes Berg <johannes@sipsolutions.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] mac80211: mesh: fixed HT ies in beacon template
Date	2016-07-18 21:00 +0200
Message-ID	<rWlVL-1wg-5@gated-at.bofh.it> (permalink)
References	<rUqPU-2ww-21@gated-at.bofh.it> <rWgW5-6NT-11@gated-at.bofh.it> <rWlVL-1wg-7@gated-at.bofh.it> <rWgW5-6NT-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2016-07-18 at 09:38 -0400, Bob Copeland wrote:
> On Wed, Jul 13, 2016 at 02:45:40PM +0300, Yaniv Machani wrote:
> > The HT capab info field inside the HT capab IE of the mesh beacon
> > is incorrect (in the case of 20MHz channel width).
> > To fix this driver will check configuration from cfg and
> > will build it accordingly.
> 
> > +    /* determine capability flags */
> > +	cap = sband->ht_cap.cap;
> > +
> > +    /* if channel width is 20MHz - configure HT capab
> > accordingly*/
> > +	if (sdata->vif.bss_conf.chandef.width ==
> > NL80211_CHAN_WIDTH_20) {
> > +		cap &= ~IEEE80211_HT_CAP_SUP_WIDTH_20_40;
> > +		cap &= ~IEEE80211_HT_CAP_DSSSCCK40;
> > +	}
> 
> Is it required that HT capability match the HT operation in this
> case?
> 

Is there ever a case that HT *capability* should be restricted
artificially like that? I can't remember any cases - we do something
like that to work around broken APs in some cases, but here?

johannes

Thread

[PATCH 3/3] mac80211: mesh: fixed HT ies in beacon template Yaniv Machani <yanivma@ti.com> - 2016-07-13 13:50 +0200
  Re: [PATCH 3/3] mac80211: mesh: fixed HT ies in beacon template Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-07-13 14:40 +0200
  Re: [PATCH 3/3] mac80211: mesh: fixed HT ies in beacon template Bob Copeland <me@bobcopeland.com> - 2016-07-18 15:40 +0200
    Re: [PATCH 3/3] mac80211: mesh: fixed HT ies in beacon template Johannes Berg <johannes@sipsolutions.net> - 2016-07-18 21:00 +0200
      RE: [PATCH 3/3] mac80211: mesh: fixed HT ies in beacon template "Machani, Yaniv" <yanivma@ti.com> - 2016-07-19 15:20 +0200

csiph-web