Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1445651

[PATCH v2 2/2] led: is31fl32xx: define complete i2c_device_id table

Show all headers | View raw

Otherwise the driver module will not be automatically probed.

Fixes: 9d7cffaf99f5 ("leds: Add driver for the ISSI IS31FL32xx family
of LED controllers")
Fixes: e0442d7def8f ("leds: Add SN3218 and SN3216 support to the
IS31FL32XX driver")

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Tested-by: David Rivshin <drivshin@allworx.com>
Acked-by: David Rivshin <drivshin@allworx.com>
---
 drivers/leds/leds-is31fl32xx.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c
index a53b71e..478844c 100644
--- a/drivers/leds/leds-is31fl32xx.c
+++ b/drivers/leds/leds-is31fl32xx.c
@@ -482,10 +482,16 @@ static int is31fl32xx_remove(struct i2c_client *client)
 }
 
 /*
- * i2c-core requires that id_table be non-NULL, even though
- * it is not used for DeviceTree based instantiation.
+ * i2c-core (and modalias) requires that id_table be properly filled,
+ * even though it is not used for DeviceTree based instantiation.
  */
 static const struct i2c_device_id is31fl32xx_id[] = {
+	{ "is31fl3236" },
+	{ "is31fl3235" },
+	{ "is31fl3218" },
+	{ "sn3218" },
+	{ "is31fl3216" },
+	{ "sn3216" },
 	{},
 };
 
-- 
2.7.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/2] led: is31fl32xx: minor improvements "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-07-18 19:10 +0200
  [PATCH v2 1/2] led: is31fl32xx: fix typo in id and match table names "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-07-18 19:10 +0200
  [PATCH v2 2/2] led: is31fl32xx: define complete i2c_device_id table "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-07-18 19:10 +0200
  Re: [PATCH v2 0/2] led: is31fl32xx: minor improvements Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-07-19 09:00 +0200

csiph-web