Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1445604

[PATCH] kconfig: tinyconfig: provide whole choice blocks to avoid warnings

Show all headers | View raw

Using "make tinyconfig" produces a couple of annoying warnings that show up
for build test machines all the time:

    .config:966:warning: override: NOHIGHMEM changes choice state
    .config:965:warning: override: SLOB changes choice state
    .config:963:warning: override: KERNEL_XZ changes choice state
    .config:962:warning: override: CC_OPTIMIZE_FOR_SIZE changes choice state
    .config:933:warning: override: SLOB changes choice state
    .config:930:warning: override: CC_OPTIMIZE_FOR_SIZE changes choice state
    .config:870:warning: override: SLOB changes choice state
    .config:868:warning: override: KERNEL_XZ changes choice state
    .config:867:warning: override: CC_OPTIMIZE_FOR_SIZE changes choice state

I've made a previous attempt at fixing them and we discussed a number of
alternatives.

I tried changing the Makefile to use "merge_config.sh -n $(fragment-list)"
but couldn't get that to work properly.

This is yet another approach, based on the observation that we do want
to see a warning for conflicting 'choice' options, and that we can simply
make them non-conflicting by listing all other options as disabled.
This is a trivial patch that we can apply independent of plans for other
changes.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://storage.kernelci.org/mainline/v4.7-rc6/x86-tinyconfig/build.log
https://patchwork.kernel.org/patch/9212749/
---
 kernel/configs/tiny.config | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/kernel/configs/tiny.config b/kernel/configs/tiny.config
index c2de56ab0fce..3eeade4d876d 100644
--- a/kernel/configs/tiny.config
+++ b/kernel/configs/tiny.config
@@ -1,4 +1,12 @@
 CONFIG_CC_OPTIMIZE_FOR_SIZE=y
+# CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE is not set
 CONFIG_KERNEL_XZ=y
+# CONFIG_KERNEL_GZIP is not set
+# CONFIG_KERNEL_BZIP2 is not set
+# CONFIG_KERNEL_LZMA is not set
+# CONFIG_KERNEL_LZO is not set
+# CONFIG_KERNEL_LZ4 is not set
 CONFIG_OPTIMIZE_INLINING=y
+# CONFIG_SLUB is not set
+# CONFIG_SLAB is not set
 CONFIG_SLOB=y
-- 
2.9.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] kconfig: tinyconfig: provide whole choice blocks to avoid warnings Arnd Bergmann <arnd@arndb.de> - 2016-07-18 18:10 +0200
  Re: [PATCH] kconfig: tinyconfig: provide whole choice blocks to  avoid warnings Josh Triplett <josh@joshtriplett.org> - 2016-07-18 21:40 +0200
    Re: [PATCH] kconfig: tinyconfig: provide whole choice blocks to avoid warnings Arnd Bergmann <arnd@arndb.de> - 2016-07-18 22:00 +0200
  [PATCH 1/1] kconfig: tinyconfig: x86: List disabled choices to avoid  warning Josh Triplett <josh@joshtriplett.org> - 2016-07-18 21:40 +0200
  Re: [PATCH] kconfig: tinyconfig: provide whole choice blocks to avoid warnings Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-07-21 03:30 +0200

csiph-web