Re: [PATCH v8 2/4] i2c-smbus: add SMBus Host Notify support

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Jean Delvare <jdelvare@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 2/4] i2c-smbus: add SMBus Host Notify support
Date	Mon, 18 Jul 2016 18:50:02 +0200
Message-ID	<rWjTY-fe-33@gated-at.bofh.it> (permalink)
References	<rI9B7-7JN-5@gated-at.bofh.it> <rI9B8-7JN-15@gated-at.bofh.it> <rWdbP-4qS-1@gated-at.bofh.it> <rWj7z-89r-1@gated-at.bofh.it>
X-Original-To	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Organization	SUSE Linux
X-Mailer	Claws Mail 3.12.0 (GTK+ 2.24.30; x86_64-suse-linux-gnu)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
X-Original-Cc	Wolfram Sang <wsa@the-dreams.de>, Jonathan Corbet <corbet@lwn.net>, Corey Minyard <minyard@acm.org>, Guenter Roeck <linux@roeck-us.net>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Andrew Duggan <aduggan@synaptics.com>, Christopher Heiny <cheiny@synaptics.com>, linux-i2c@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
X-Original-Date	Mon, 18 Jul 2016 18:47:12 +0200
X-Original-Message-ID	<20160718184712.4ad7ce58@endymion>
X-Original-References	<1465484030-28838-1-git-send-email-benjamin.tissoires@redhat.com> <1465484030-28838-3-git-send-email-benjamin.tissoires@redhat.com> <20160718113721.2eaa86d3@endymion> <20160718155902.GS4663@mail.corp.redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1445639

Show key headers only | View raw

On Mon, 18 Jul 2016 17:59:02 +0200, Benjamin Tissoires wrote:
> On Jul 18 2016 or thereabouts, Jean Delvare wrote:
> > You provide stubs for SMBus Host Notify support if CONFIG_I2C_SMBUS is
> > not selected. There are no such stubs for SMBus Alert support, for which
> > I assumed drivers would select I2C_SMBUS if they have support. Which is
> > what you are actually doing for i2c-i801 in a latter patch.
> > 
> > Is there any reason for this difference? For consistency I'd rather
> > provide stubs for all or none. My preference being for none, unless you
> > have a use case which requires them.
> 
> Looks like you are right. There is no need for the stubs and they can be
> dropped. I think I had them in the first place for a previous
> implementation, and they just stayed here.
> 
> Given that you already sent a few cleanup patches, do you want to send
> this fix also, or do you expect me to send it? (I don't think there will
> be a conflict, so either is fine).

I can do it, I just wanted to make sure it was OK with you first.

-- 
Jean Delvare
SUSE L3 Support

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v8 2/4] i2c-smbus: add SMBus Host Notify support Jean Delvare <jdelvare@suse.de> - 2016-07-18 11:40 +0200
  Re: [PATCH v8 2/4] i2c-smbus: add SMBus Host Notify support Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-07-18 18:00 +0200
    Re: [PATCH v8 2/4] i2c-smbus: add SMBus Host Notify support Jean Delvare <jdelvare@suse.de> - 2016-07-18 18:50 +0200

csiph-web