[PATCH 1/3] mm, vmscan: Remove redundant check in shrink_zones()

From	Mel Gorman <mgorman@techsingularity.net>
Newsgroups	linux.kernel
Subject	[PATCH 1/3] mm, vmscan: Remove redundant check in shrink_zones()
Date	2016-07-18 17:00 +0200
Message-ID	<rWibv-7xJ-11@gated-at.bofh.it> (permalink)
References	<rWibv-7xJ-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

As pointed out by Minchan Kim, shrink_zones() checks for populated
zones in a zonelist but a zonelist can never contain unpopulated
zones. While it's not related to the node-lru series, it can be
cleaned up now.

Suggested-by: Minchan Kim <minchan@kernel.org>
Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
---
 mm/vmscan.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 3f06a7a0d135..45344acf52ba 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2605,9 +2605,6 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc)
 
 	for_each_zone_zonelist_nodemask(zone, z, zonelist,
 					sc->reclaim_idx, sc->nodemask) {
-		if (!populated_zone(zone))
-			continue;
-
 		/*
 		 * Take care memory controller reclaiming has small influence
 		 * to global LRU.
-- 
2.6.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] mm, vmscan: Remove redundant check in shrink_zones() Mel Gorman <mgorman@techsingularity.net> - 2016-07-18 17:00 +0200
  Re: [PATCH 1/3] mm, vmscan: Remove redundant check in shrink_zones() Johannes Weiner <hannes@cmpxchg.org> - 2016-07-18 18:20 +0200
  Re: [PATCH 1/3] mm, vmscan: Remove redundant check in shrink_zones() Minchan Kim <minchan@kernel.org> - 2016-07-19 02:00 +0200

csiph-web