Re: [PATCH] mmc: block: fix free of uninitialized 'idata->buf'

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Ulf Hansson <ulf.hansson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mmc: block: fix free of uninitialized 'idata->buf'
Date	Mon, 18 Jul 2016 13:20:01 +0200
Message-ID	<rWeKB-5sp-15@gated-at.bofh.it> (permalink)
References	<rSGcq-6ES-15@gated-at.bofh.it> <rU2NA-3tA-15@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=nYsm7f0sStIY2UMmJJVkIZdI3q2UGRCvcnzGbYapVoQ=; b=aO7J/BdnEyDo0BjR77Uvqt6X6luGG1A4NOFvZDpO95UTPf3+RUkWGuomARwXrJJhKe a91Fr+Q9TaVUM5Qge6o4RehA3oA6APoYyGA7ZNLXRYnFT8KNA9MGgXOBhaepgQ3odG5r cIVS6wto6VjZOa2drCaMWjHOsnvOsh/i9t8nk=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nYsm7f0sStIY2UMmJJVkIZdI3q2UGRCvcnzGbYapVoQ=; b=IUsnS4ecseHXGV4plNpqQaC2WfP/nit0csT4IOGPV2Z+VSPzeOOiG1BBUnEsfyBIFQ GsSEAWKqCbtcs0yi1m+Fbo8h7flxnjJA0lLFTwmhxsetbzJoMV/6ExAFyBrG29Y8wiI2 WiR/Ly6QVPG1zbHyCtLUSPlEIAdUIr1Foog7ID8s+QiWyQqP5wjFBb+lEyWh1zjKk6U6 rZJkPw+fgmHVtXb+HUDWsu6/gtkcScB21x2XmjeCfaJFB/9r1jC8GIo94IKsLVfo9s3q WoSfefW1zLsUSaOoaE8aM0cproIYM7JkrfMqTsmiws3qR+6lU6hqFU+HH7S072MGExTI Wb9g==
X-Gm-Message-State	ALyK8tJp2IsUXP5MIwEaZHNV73BdgXapv3nPUaRsQhGvgda7yMWhkhSFsc01kx5JgFQy4BLCo49ggGsKTjo31eFO
X-Received	by 10.28.7.20 with SMTP id 20mr39175849wmh.52.1468840779647; Mon, 18 Jul 2016 04:19:39 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	18
Organization	linux.* mail to news gateway
X-Original-Cc	linux-mmc <linux-mmc@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, stable <stable@vger.kernel.org>
X-Original-Date	Mon, 18 Jul 2016 13:19:38 +0200
X-Original-Message-ID	<CAPDyKFph2uiiC66Tw6xnTWOSSjzkUz-DOHYPXuBHJEtopw9Jtg@mail.gmail.com>
X-Original-References	<1467991622-11036-1-git-send-email-ville@tuxera.com> <CAPDyKFpEPW-7FrpRceJACkg9uY3FcutPtCNnpxA8uQSE4arnuQ@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1445384

Show key headers only | View raw

On 12 July 2016 at 12:07, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> + stable
>
> On 8 July 2016 at 17:27, Ville Viinikka <ville@tuxera.com> wrote:
>> Set 'idata->buf' to NULL so that it never gets returned without
>> initialization. This fixes a bug where mmc_blk_ioctl_cmd() would
>> free both 'idata' and 'idata->buf' but 'idata->buf' was returned
>> uninitialized.
>>
>> Fixes: 1ff8950c0433 ("mmc: block: change to use kmalloc when copy data from userspace")
>> Signed-off-by: Ville Viinikka <ville@tuxera.com>
>
> I added a stable tag to this and applied it for next!

Moved this to fixes!

Kind regards
Uffe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mmc: block: fix free of uninitialized 'idata->buf' Ulf Hansson <ulf.hansson@linaro.org> - 2016-07-12 12:10 +0200
  Re: [PATCH] mmc: block: fix free of uninitialized 'idata->buf' Ulf Hansson <ulf.hansson@linaro.org> - 2016-07-18 13:20 +0200

csiph-web