linux-next: build failure after merge of the tip tree

From	Stephen Rothwell <sfr@canb.auug.org.au>
Newsgroups	linux.kernel
Subject	linux-next: build failure after merge of the tip tree
Date	2016-07-18 10:30 +0200
Message-ID	<rWc66-3Ku-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi all,

After merging the tip tree, today's linux-next build (x86_64 allnoconfig)
failed like this:

In file included from arch/x86/kernel/x8664_ksyms_64.c:10:0:
arch/x86/include/asm/pgtable.h:38:8: error: unknown type name 'spinlock_t'
 extern spinlock_t pgd_lock;
        ^

Probably caused by commit

  186f43608a5c ("x86/kernel: Audit and remove any unnecessary uses of module.h")

I added this patch for today (maybe adding the include to
arch/x86/include/asm/pgtable.h would be better?):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 18 Jul 2016 18:23:24 +1000
Subject: [PATCH] x86/kernel: include spinlock_types.h for missing spinlock_t

Fixes: 186f43608a5c ("x86/kernel: Audit and remove any unnecessary uses of module.h")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/x86/kernel/x8664_ksyms_64.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/kernel/x8664_ksyms_64.c b/arch/x86/kernel/x8664_ksyms_64.c
index f6d30fedcc03..95e49f6e4fc3 100644
--- a/arch/x86/kernel/x8664_ksyms_64.c
+++ b/arch/x86/kernel/x8664_ksyms_64.c
@@ -2,6 +2,7 @@
    All C exports should go in the respective C files. */
 
 #include <linux/export.h>
+#include <linux/spinlock_types.h>
 #include <linux/smp.h>
 
 #include <net/checksum.h>
-- 
2.8.1

-- 
Cheers,
Stephen Rothwell

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

linux-next: build failure after merge of the tip tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-07-18 10:30 +0200
  Re: linux-next: build failure after merge of the tip tree Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-18 16:30 +0200
  [tip:x86/headers] x86/headers: Include spinlock_types.h in  x8664_ksyms_64.c for missing spinlock_t tip-bot for Stephen Rothwell <tipbot@zytor.com> - 2016-07-19 10:10 +0200

csiph-web