Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1447223

Re: [PATCH] radix-tree: fix comment about "exceptional" bits

Show all headers | View raw

On Wed, Jul 20, 2016 at 12:55:31AM -0600, Ross Zwisler wrote:
> The bottom two bits of radix tree entries are reserved for special use by
> the radix tree code itself.  A comment detailing their usage was added by:
> 
> commit 3bcadd6fa6c4 ("radix-tree: free up the bottom bit of exceptional
> entries for reuse")
> 
> This comment states that if the bottom two bits are '11', this means that
> this is a locked exceptional entry.
> 
> It turns out that this bit combination was never actually used.  Radix tree
> locking for DAX was indeed implemented, but it actually used the third LSB:
> 
>   /* We use lowest available exceptional entry bit for locking */
>   #define RADIX_DAX_ENTRY_LOCK (1 << RADIX_TREE_EXCEPTIONAL_SHIFT)
> 
> This locking code was also made specific to the DAX code instead of being
> generally implemented in radix-tree.h.
> 
> So, fix the comment.
> 
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] radix-tree: fix comment about "exceptional" bits Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-07-20 09:00 +0200
  Re: [PATCH] radix-tree: fix comment about "exceptional" bits Johannes Thumshirn <jthumshirn@suse.de> - 2016-07-20 15:20 +0200

csiph-web