Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1447149

Re: [PATCH 0/6] radio: Utilize the module_isa_driver macro

From Hans Verkuil <hverkuil@xs4all.nl>
Newsgroups linux.kernel
Subject Re: [PATCH 0/6] radio: Utilize the module_isa_driver macro
Date 2016-07-20 12:40 +0200
Message-ID <rWX4Z-b1-7@gated-at.bofh.it> (permalink)
References <rWi1P-7tY-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 07/18/2016 04:45 PM, William Breathitt Gray wrote:
> The module_isa_driver macro is a helper macro for ISA drivers which do
> not do anything special in module init/exit. This patchset eliminates a
> lot of ISA driver registration boilerplate code by utilizing
> module_isa_driver, which replaces module_init and module_exit.
> 
> William Breathitt Gray (6):
>   radio: terratec: Utilize the module_isa_driver macro
>   radio: rtrack2: Utilize the module_isa_driver macro
>   radio: trust: Utilize the module_isa_driver macro
>   radio: zoltrix: Utilize the module_isa_driver macro
>   radio: aztech: Utilize the module_isa_driver macro
>   radio: aimslab: Utilize the module_isa_driver macro

Good idea, but it doesn't compile:

module_isa_driver(terratec_driver.driver, 1);

expands to:

static int __init terratec_driver.driver_init(void)
{
        return isa_register_driver(&(terratec_driver.driver), 1);
}

So now the function name contains a '.' and it won't compile.

Regards,

	Hans

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] radio: Utilize the module_isa_driver macro William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-07-18 16:50 +0200
  [PATCH 3/6] radio: trust: Utilize the module_isa_driver macro William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-07-18 16:50 +0200
  [PATCH 4/6] radio: zoltrix: Utilize the module_isa_driver macro William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-07-18 16:50 +0200
  [PATCH 5/6] radio: aztech: Utilize the module_isa_driver macro William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-07-18 16:50 +0200
  [PATCH 6/6] radio: aimslab: Utilize the module_isa_driver macro William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-07-18 16:50 +0200
  [PATCH 1/6] radio: terratec: Utilize the module_isa_driver macro William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-07-18 16:50 +0200
  [PATCH 2/6] radio: rtrack2: Utilize the module_isa_driver macro William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-07-18 16:50 +0200
  Re: [PATCH 0/6] radio: Utilize the module_isa_driver macro Hans Verkuil <hverkuil@xs4all.nl> - 2016-07-20 12:40 +0200
    Re: [PATCH 0/6] radio: Utilize the module_isa_driver macro William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-07-20 14:50 +0200

csiph-web