Re: [PATCH 1/1] netfilter: Add helper array register/unregister functions

From	Pablo Neira Ayuso <pablo@netfilter.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] netfilter: Add helper array register/unregister functions
Date	2016-07-20 10:50 +0200
Message-ID	<rWVmx-7w8-7@gated-at.bofh.it> (permalink)
References	<rW7J8-X0-7@gated-at.bofh.it> <rWO1H-2Kq-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Jul 20, 2016 at 08:51:17AM +0800, Liping Zhang wrote:
> 2016-07-18 11:39 GMT+08:00  <fgao@ikuai8.com>:
> > From: Gao Feng <fgao@ikuai8.com>
> >
> > Add nf_ct_helper_init, nf_conntrack_helpers_register/unregister
> > functions to enhance the conntrack helper codes.
> 
> I think this patch is breaking something ...
> 
> This irc:
> > -               if (ports[i] == IRC_PORT)
> > -                       sprintf(irc[i].name, "irc");
> > -               else
> > -                       sprintf(irc[i].name, "irc-%u", i);
> > -
> > -               ret = nf_conntrack_helper_register(&irc[i]);
> > +               nf_ct_helper_init(&irc[i], AF_INET, IPPROTO_TCP, "irc",
> > +                                 IRC_PORT, ports[i], &irc_exp_policy, 0, 0,
> > +                                 help, NULL, THIS_MODULE);
> > +       }
> 
> This sip:
> > -                       if (ports[i] == SIP_PORT)
> > -                               sprintf(sip[i][j].name, "sip");
> > -                       else
> > -                               sprintf(sip[i][j].name, "sip-%u", i);
> 
> And this tftp:
> > -                       if (ports[i] == TFTP_PORT)
> > -                               sprintf(tftp[i][j].name, "tftp");
> > -                       else
> > -                               sprintf(tftp[i][j].name, "tftp-%u", i);
> 
> For example, if the user install the nf_conntrack_tftp module an
> specify the ports to "69,10069",
> then the helper name is "tftp" and "tftp-1".
> 
> But apply this patch, the helper name will be changed to "tftp" and
> "tftp-10069", this may break the
> existing iptables rules which used the helper match or CT target.
>
> And this was already discussed  at
> https://patchwork.ozlabs.org/patch/622238/

Thanks for spotting this.

I'm going to collapse this patch that I'm attaching to Feng's work to
address this.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] netfilter: Add helper array register/unregister functions fgao@ikuai8.com - 2016-07-18 05:50 +0200
  Re: [PATCH 1/1] netfilter: Add helper array register/unregister  functions Pablo Neira Ayuso <pablo@netfilter.org> - 2016-07-19 20:20 +0200
    Re: 答复: [PATCH 1/1] netfilter:  Add helper array register/unregister functions Pablo Neira Ayuso <pablo@netfilter.org> - 2016-07-20 11:00 +0200
      答复: 答复: [PATCH 1/1] netfilter: Add helper array register/unregister functions 高峰 <fgao@ikuai8.com> - 2016-07-20 11:20 +0200
  Re: [PATCH 1/1] netfilter: Add helper array register/unregister functions Liping Zhang <zlpnobody@gmail.com> - 2016-07-20 03:00 +0200
    答复: [PATCH 1/1] netfilter: Add helper array register/unregister functions 高峰 <fgao@ikuai8.com> - 2016-07-20 03:10 +0200
      Re: 答复: [PATCH 1/1] netfilter:  Add helper array register/unregister functions Pablo Neira Ayuso <pablo@netfilter.org> - 2016-07-20 10:50 +0200
    Re: [PATCH 1/1] netfilter: Add helper array register/unregister  functions Pablo Neira Ayuso <pablo@netfilter.org> - 2016-07-20 10:50 +0200

csiph-web