Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1447115

RE: [PATCH v5 4/8] char: rpmb: provide a user space interface

Show all headers | View raw

> 
> On Mon, Jul 18, 2016 at 4:27 PM, Tomas Winkler <tomas.winkler@intel.com>
> wrote:
> > The user space API is achieved via two synchronous IOCTL.
> > Simplified one, RPMB_IOC_REQ_CMD, were read result cycles is
> performed
> > by the framework on behalf the user and second, RPMB_IOC_SEQ_CMD
> where
> > the whole RPMB sequence including RESULT_READ is supplied by the caller.
> > The latter is intended for  easier adjusting  of the  applications
> > that use MMC_IOC_MULTI_CMD ioctl.
> >
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > ---
> 
> [...]
> 
> > diff --git a/drivers/char/rpmb/Kconfig b/drivers/char/rpmb/Kconfig
> > index c5e6e909efce..6794be9fcc5e 100644
> > --- a/drivers/char/rpmb/Kconfig
> > +++ b/drivers/char/rpmb/Kconfig
> > @@ -6,3 +6,10 @@ config RPMB
> >           access RPMB partition.
> >
> >           If unsure, select N.
> > +
> > +config RPMB_INTF_DEV
> > +       bool "RPMB character device interface /dev/rpmbN"
> 
> A bool Kconfig should ideally....
> 
> > +       depends on RPMB
> > +       help
> > +         Say yes here if you want to access RPMB from user space
> > +         via character device interface /dev/rpmb%d
> > diff --git a/drivers/char/rpmb/Makefile b/drivers/char/rpmb/Makefile
> > index 812b3ed264c0..b5dc087b1299 100644
> > --- a/drivers/char/rpmb/Makefile
> > +++ b/drivers/char/rpmb/Makefile
> > @@ -1,4 +1,5 @@
> >  obj-$(CONFIG_RPMB) += rpmb.o
> >  rpmb-objs += core.o
> > +rpmb-$(CONFIG_RPMB_INTF_DEV) += cdev.o

This is not a builtin, this is an optional part of the module 

> > +#include <linux/module.h>
> 
> ....not use module.h or any MODULE_ macros from within it.

Can be dropped in this case as no macros are used, 
but the pattern Kconfig bool -> no include module.h  you are following has false positive cases.

Thanks
Tomas

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/8] Replay Protected Memory Block (RPMB) subsystem Tomas Winkler <tomas.winkler@intel.com> - 2016-07-18 22:30 +0200
  [PATCH v5 3/8] char: rpmb: add device attributes Tomas Winkler <tomas.winkler@intel.com> - 2016-07-18 22:30 +0200
  [PATCH v5 4/8] char: rpmb: provide a user space interface Tomas Winkler <tomas.winkler@intel.com> - 2016-07-18 22:30 +0200
    Re: [PATCH v5 4/8] char: rpmb: provide a user space interface Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-19 00:20 +0200
      RE: [PATCH v5 4/8] char: rpmb: provide a user space interface "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-07-20 11:10 +0200
        Re: [PATCH v5 4/8] char: rpmb: provide a user space interface Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-20 16:30 +0200
  [PATCH v5 5/8] char: rpmb: add RPMB simulation device Tomas Winkler <tomas.winkler@intel.com> - 2016-07-18 22:40 +0200
  [PATCH v5 8/8] scsi: ufs: connect to RPMB subsystem Tomas Winkler <tomas.winkler@intel.com> - 2016-07-18 22:40 +0200
  [PATCH v5 6/8] tools rpmb: add RPBM access tool Tomas Winkler <tomas.winkler@intel.com> - 2016-07-18 22:40 +0200
  [PATCH v5 7/8] mmc: block: register RPMB partition with the RPMB subsystem Tomas Winkler <tomas.winkler@intel.com> - 2016-07-18 22:40 +0200
  RE: [PATCH v5 0/8] Replay Protected Memory Block (RPMB) subsystem "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-07-23 09:50 +0200

csiph-web