Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1447074

Re: [PATCH 1/1] usb: xhci: Fix panic if disconnect

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Jim,

Jim Lin <jilin@nvidia.com> writes:
> After a device is disconnected, xhci_stop_device() will be invoked
> in xhci_bus_suspend().
> Also the "disconnect" IRQ will have ISR to invoke
> xhci_free_virt_device() in this sequence.
> xhci_irq -> xhci_handle_event -> handle_cmd_completion ->
> xhci_handle_cmd_disable_slot -> xhci_free_virt_device
>
> If xhci->devs[slot_id] has been assigned to NULL in
> xhci_free_virt_device(), then virt_dev->eps[i].ring in
> xhci_stop_device() may point to an invlid address to cause kernel
> panic.
>
> virt_dev = xhci->devs[slot_id];
> :
> if (virt_dev->eps[i].ring && virt_dev->eps[i].ring->dequeue)
>
> [] Unable to handle kernel paging request at virtual address 00001a68
> [] pgdÿffffc001430000
> [] [00001a68] *pgd0000013c807003, *pud0000013c807003,
> *pmd0000013c808003, *pte00000000000000
> [] Internal error: Oops: 96000006 [#1] PREEMPT SMP
> [] CPU: 0 PID: 39 Comm: kworker/0:1 Tainted: G     U
> [] Workqueue: pm pm_runtime_work
> [] task: ffffffc0bc0e0bc0 ti: ffffffc0bc0ec000 task.ti:
> ffffffc0bc0ec000
> [] PC is at xhci_stop_device.constprop.11+0xb4/0x1a4
>
> This issue is found when running with realtek ethernet device
> (0bda:8153).
>
> Signed-off-by: Jim Lin <jilin@nvidia.com>

yes, I saw the previous version :-) So, we're pretty close to getting
the merge window opened. This will defer to v4.8-rc1.

Patch looks good, though. :-)

thanks

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] usb: xhci: Fix panic if disconnect Jim Lin <jilin@nvidia.com> - 2016-07-20 10:10 +0200
  Re: [PATCH 1/1] usb: xhci: Fix panic if disconnect Felipe Balbi <balbi@kernel.org> - 2016-07-20 10:20 +0200

csiph-web