Re: [PATCH 0/3] Enable legacy irq mode before jump to kexec/kdump kernel

From	"bhe@redhat.com" <bhe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/3] Enable legacy irq mode before jump to kexec/kdump kernel
Date	2016-07-20 08:50 +0200
Message-ID	<rWTuq-6ma-9@gated-at.bofh.it> (permalink)
References	<rWPTP-41h-15@gated-at.bofh.it> <rWQPT-4zq-5@gated-at.bofh.it> <rWR9f-4VD-13@gated-at.bofh.it> <rWTkK-6iI-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/20/16 at 08:32am, Thomas Gleixner wrote:
> On Wed, 20 Jul 2016, bhe@redhat.com wrote:
> > On 07/20/16 at 03:54am, Wei, Jiangang wrote:
> >
> > >  In fact, Eric and Ingo suggested that "it should be fixed in the bootup
> > > path of the dump kernel, not the crash kernel reboot path", which is
> > > convincing and reasonable.
> > 
> > Well this patch doesn't do differently with Eric's original implemention
> > in kexec/kdump path.
> > By taking out clear_IO_APIC from disable_IO_APIC, the left code of
> > disable_IO_APIC will only do the virtual wire setting. So for
> > kexec/kdump path, code basically is the same as Eric's method. But for
> > poweroff/halt/reboot, it's enough to call clear_IO_APIC to disable
> > IO-APIC.
> 
> You're completely ignoring what Jiangang said: 
> 
>  "it should be fixed in the bootup path of the dump kernel, not the crash
>   kernel reboot path"
> 
> and that's the right way to do it. End of story.

Thanks, tglx. What I did is like reverting commit 522e6646446. But it
would be great if we can change to fix it in bootup path.

Thanks
Baoquan

Thread

[PATCH 0/3] Enable legacy irq mode before jump to kexec/kdump kernel Baoquan He <bhe@redhat.com> - 2016-07-20 05:00 +0200
  Re: [PATCH 0/3] Enable legacy irq mode before jump to kexec/kdump  kernel "Wei, Jiangang" <weijg.fnst@cn.fujitsu.com> - 2016-07-20 06:00 +0200
    Re: [PATCH 0/3] Enable legacy irq mode before jump to kexec/kdump  kernel "bhe@redhat.com" <bhe@redhat.com> - 2016-07-20 06:20 +0200
      Re: [PATCH 0/3] Enable legacy irq mode before jump to kexec/kdump  kernel Thomas Gleixner <tglx@linutronix.de> - 2016-07-20 08:40 +0200
        Re: [PATCH 0/3] Enable legacy irq mode before jump to kexec/kdump  kernel "bhe@redhat.com" <bhe@redhat.com> - 2016-07-20 08:50 +0200
    Re: [PATCH 0/3] Enable legacy irq mode before jump to kexec/kdump  kernel "bhe@redhat.com" <bhe@redhat.com> - 2016-07-20 08:30 +0200

csiph-web