Re: [PATCH v2 01/10] binfmt_flat: assorted cleanups

From	Greg Ungerer <gerg@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 01/10] binfmt_flat: assorted cleanups
Date	2016-07-20 09:20 +0200
Message-ID	<rWTXs-6L3-13@gated-at.bofh.it> (permalink)
References	(1 earlier) <rW7zs-T6-23@gated-at.bofh.it> <rWvs5-8aD-9@gated-at.bofh.it> <rWx0R-BC-23@gated-at.bofh.it> <rWR9f-4VD-11@gated-at.bofh.it> <rWTE6-6ph-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Geert,

On 20/07/16 16:54, Geert Uytterhoeven wrote:
> Hi Nicolas,
> 
> On Wed, Jul 20, 2016 at 6:09 AM, Nicolas Pitre <nicolas.pitre@linaro.org> wrote:
>> On Tue, 19 Jul 2016, Geert Uytterhoeven wrote:
>>
>>> On Tue, Jul 19, 2016 at 6:52 AM, Greg Ungerer <gerg@linux-m68k.org> wrote:
>>>> Seeing as you have modified quite a few printk calls is it worth
>>>> while annotating them with appropriate KERN_ERR, KERN_INFO, etc?
>>>
>>> You mean pr_err(), pr_info(), ... ;-)
>>
>> Done.  Included in v3.
> 
> Really? The only change in v3 is the Reviewed-by?

Patch 2 in the series now does this:

[PATCH v3 02/12] binfmt_flat: convert printk invocations to their modern form

Regards
Greg


> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
>

Thread

[PULL REQUEST] [PATCH v2 00/10] allow BFLT executables on systems with a MMU Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-18 05:40 +0200
  [PATCH v2 07/10] binfmt_flat: use clear_user() rather than memset() to clear .bss Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-18 05:40 +0200
  [PATCH v2 02/10] elf_fdpic_transfer_args_to_stack(): make it generic Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-18 05:40 +0200
  [PATCH v2 03/10] binfmt_flat: use generic transfer_args_to_stack() Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-18 05:40 +0200
  [PATCH v2 06/10] binfmt_flat: use proper user space accessors with old relocs code Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-18 05:40 +0200
  [PATCH v2 01/10] binfmt_flat: assorted cleanups Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-18 05:40 +0200
    Re: [PATCH v2 01/10] binfmt_flat: assorted cleanups Greg Ungerer <gerg@linux-m68k.org> - 2016-07-19 07:10 +0200
      Re: [PATCH v2 01/10] binfmt_flat: assorted cleanups Geert Uytterhoeven <geert@linux-m68k.org> - 2016-07-19 08:50 +0200
        Re: [PATCH v2 01/10] binfmt_flat: assorted cleanups Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-20 06:20 +0200
          Re: [PATCH v2 01/10] binfmt_flat: assorted cleanups Geert Uytterhoeven <geert@linux-m68k.org> - 2016-07-20 09:00 +0200
            Re: [PATCH v2 01/10] binfmt_flat: assorted cleanups Greg Ungerer <gerg@linux-m68k.org> - 2016-07-20 09:20 +0200
  [PATCH v2 09/10] binfmt_flat: add MMU-specific support Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-18 05:50 +0200
  [PATCH v2 04/10] binfmt_flat: clean up create_flat_tables() and stack accesses Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-18 05:50 +0200
  [PATCH v2 08/10] binfmt_flat: update libraries' data segment pointer with userspace accessors Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-18 05:50 +0200
  Re: [PULL REQUEST] [PATCH v2 00/10] allow BFLT executables on systems  with a MMU Greg Ungerer <gerg@linux-m68k.org> - 2016-07-19 09:30 +0200

csiph-web