Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1446972

Re: [PATCH v3 02/12] binfmt_flat: convert printk invocations to their modern form

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, 19 Jul 2016, Joe Perches wrote:

> On Wed, 2016-07-20 at 00:20 -0400, Nicolas Pitre wrote:
> > diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c
> []
> > @@ -15,6 +15,8 @@
> >   *	JAN/99 -- coded full program relocation (gerg@snapgear.com)
> >   */
> >  
> > +#define pr_fmt(fmt)	"BINFMT_FLAT: : " fmt
> 
> Why the double colon?

Go figure.

> Much more common would be
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

Sure. I used the all-caps version as that's what most former printk's 
used. But if you say KBUILD_MODNAME is more common then I have no issue 
with that.

> 
> > @@ -106,8 +98,8 @@ static struct linux_binfmt flat_format = {
> >  
> >  static int flat_core_dump(struct coredump_params *cprm)
> >  {
> > -	printk("Process %s:%d received signr %d and should have core dumped\n",
> > -			current->comm, current->pid, cprm->siginfo->si_signo);
> > +	pr_warning("Process %s:%d received signr %d and should have core dumped\n",
> > +		   current->comm, current->pid, cprm->siginfo->si_signo);
> 
> Prefer pr_warn

OK.

Updated in my repo and pushed out.

> >  	return(1);
> >  }
> >  
> > @@ -190,17 +182,17 @@ static int decompress_exec(
> >  	loff_t fpos;
> >  	int ret, retval;
> >  
> > -	DBG_FLT("decompress_exec(offset=%lx,buf=%p,len=%lx)\n",offset, dst, len);
> > +	pr_debug("decompress_exec(offset=%lx,buf=%p,len=%lx)\n",offset, dst, len);
> 
> Generally unnecessary as the function tracer works well

Not necessarily on uClinux where you might not aford it.

And this patch is about converting existing printk()'s so if some of 
them should be removed then it would be best to do that separately.

> >  	memset(&strm, 0, sizeof(strm));
> >  	strm.workspace = kmalloc(zlib_inflate_workspacesize(), GFP_KERNEL);
> >  	if (strm.workspace == NULL) {
> > -		DBG_FLT("binfmt_flat: no memory for decompress workspace\n");
> > +		pr_debug("no memory for decompress workspace\n");
> >  		return -ENOMEM;
> >  	}
> >  	buf = kmalloc(LBUFSIZE, GFP_KERNEL);
> >  	if (buf == NULL) {
> > -		DBG_FLT("binfmt_flat: no memory for read buffer\n");
> > +		pr_debug("no memory for read buffer\n");
> 
> Unnecessary OOM messages as allocs do a stack dump

Again this should probably be done separately.


Nicolas

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/12] allow BFLT executables on systems with a MMU Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-20 06:30 +0200
  [PATCH v3 01/12] binfmt_flat: assorted cleanups Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-20 06:30 +0200
  [PATCH v3 03/12] binfmt_flat: prevent kernel dammage from corrupted executable headers Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-20 06:30 +0200
  [PATCH v3 02/12] binfmt_flat: convert printk invocations to their modern form Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-20 06:30 +0200
    Re: [PATCH v3 02/12] binfmt_flat: convert printk invocations to  their modern form Joe Perches <joe@perches.com> - 2016-07-20 06:40 +0200
      Re: [PATCH v3 02/12] binfmt_flat: convert printk invocations to  their modern form Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-20 07:10 +0200
  [PATCH v3 08/12] binfmt_flat: use proper user space accessors with old relocs code Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-20 06:30 +0200
  [PATCH v3 04/12] elf_fdpic_transfer_args_to_stack(): make it generic Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-20 06:30 +0200
  [PATCH v3 12/12] binfmt_flat: allow compressed flat binary format to work on MMU systems Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-20 06:30 +0200
  [PATCH v3 05/12] binfmt_flat: use generic transfer_args_to_stack() Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-20 06:30 +0200
  [PATCH v3 10/12] binfmt_flat: update libraries' data segment pointer with userspace accessors Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-20 06:30 +0200
  [PATCH v3 06/12] binfmt_flat: clean up create_flat_tables() and stack accesses Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-20 06:30 +0200
  [PATCH v3 07/12] binfmt_flat: use proper user space accessors with relocs processing code Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-20 06:30 +0200
  [PATCH v3 09/12] binfmt_flat: use clear_user() rather than memset() to clear .bss Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-20 06:30 +0200
    Re: [PATCH v3 09/12] binfmt_flat: use clear_user() rather than  memset() to clear .bss Greg Ungerer <gerg@linux-m68k.org> - 2016-07-20 09:20 +0200
  [PATCH v3 11/12] binfmt_flat: add MMU-specific support Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-07-20 06:30 +0200

csiph-web