Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1446829
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC][PATCH 6/7] ASoC: hisilicon: Add hi6210 i2s audio driver for hdmi audio |
| Date | 2016-07-20 02:30 +0200 |
| Message-ID | <rWNyF-2yx-5@gated-at.bofh.it> (permalink) |
| References | <rVnmV-6qg-3@gated-at.bofh.it> <rVnmV-6qg-1@gated-at.bofh.it> <rVwgx-3iP-9@gated-at.bofh.it> <rWLdv-Zu-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Tue, Jul 19, 2016 at 02:59:31PM -0700, John Stultz wrote:
> Then the probe/remove logic to register the codec, and connected it up
> with the simple card driver.
> Though it seems kind of silly to have a whole driver (and devicetree
> entry for the probe hook) just to fill and install the above
> structure. Is there a simpler way to specify that via a DT node
> instead?
Well, if you can use simple-card why not just use simple-card?
> >> +static const struct of_device_id hi6210_i2s_dt_ids[] = {
> >> + { .compatible = "hisilicon,hi6210-i2s" },
> >> + { /* sentinel */ }
> >> +};
> > The code makes this look like it's not just an I2S controller.
> I'm not sure I follow this? The dt ids make it seem like this driver
> is not an i2s controller?
No. The *code* makes this look like it's not an I2S controller. It
looks like it's a driver for a DSP/mixing block which may have an
integrated I2S controller, I pointed out things like some of the routing
control.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC][PATCH 0/7] Add HDMI audio support for HiKey John Stultz <john.stultz@linaro.org> - 2016-07-16 04:20 +0200
[RFC][PATCH 2/7] k3dma: Fix dma err offsets John Stultz <john.stultz@linaro.org> - 2016-07-16 04:20 +0200
Re: [RFC][PATCH 2/7] k3dma: Fix dma err offsets zhangfei <zhangfei.gao@linaro.org> - 2016-07-18 08:50 +0200
[RFC][PATCH 6/7] ASoC: hisilicon: Add hi6210 i2s audio driver for hdmi audio John Stultz <john.stultz@linaro.org> - 2016-07-16 04:20 +0200
Re: [RFC][PATCH 6/7] ASoC: hisilicon: Add hi6210 i2s audio driver for hdmi audio Mark Brown <broonie@kernel.org> - 2016-07-16 13:50 +0200
Re: [RFC][PATCH 6/7] ASoC: hisilicon: Add hi6210 i2s audio driver for hdmi audio John Stultz <john.stultz@linaro.org> - 2016-07-20 00:00 +0200
Re: [RFC][PATCH 6/7] ASoC: hisilicon: Add hi6210 i2s audio driver for hdmi audio Mark Brown <broonie@kernel.org> - 2016-07-20 02:30 +0200
[RFC][PATCH 1/7] k3dma: Fix hisi burst clipping John Stultz <john.stultz@linaro.org> - 2016-07-16 04:20 +0200
Re: [RFC][PATCH 1/7] k3dma: Fix hisi burst clipping zhangfei <zhangfei.gao@linaro.org> - 2016-07-18 08:40 +0200
Re: [RFC][PATCH 0/7] Add HDMI audio support for HiKey Andy Green <andy@warmcat.com> - 2016-07-16 05:30 +0200
Re: [RFC][PATCH 0/7] Add HDMI audio support for HiKey John Stultz <john.stultz@linaro.org> - 2016-07-16 05:40 +0200
Re: [RFC][PATCH 0/7] Add HDMI audio support for HiKey Mark Brown <broonie@kernel.org> - 2016-07-16 13:20 +0200
csiph-web