[PATCH 2/2] ASoC: cs53l30: Fix bit shift issue of TDM mode

From	Nicolin Chen <nicoleotsuka@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] ASoC: cs53l30: Fix bit shift issue of TDM mode
Date	2016-07-20 00:40 +0200
Message-ID	<rWLQd-1rn-13@gated-at.bofh.it> (permalink)
References	<rWLQd-1rn-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The TDM mode using PCM format now has two-bit right shift due to the
format configuration in the driver. According to Figure 4-13 in the
CS53L30 datasheet, using ASP_SCLK_INV = 0 and SHIFT_LEFT = 1 should
be the correct combination to create one-bit right shift for the DSP
type A format.

Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
---
 sound/soc/codecs/cs53l30.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
index fd5502e..2c0d9c4 100644
--- a/sound/soc/codecs/cs53l30.c
+++ b/sound/soc/codecs/cs53l30.c
@@ -592,8 +592,12 @@ static int cs53l30_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
 		aspctl1 |= CS53L30_ASP_TDM_PDN;
 		break;
 	case SND_SOC_DAIFMT_DSP_A:
-		/* Clear TDM_PDN and SHIFT_LEFT, invert SCLK */
-		aspcfg |= CS53L30_ASP_SCLK_INV;
+		/*
+		 * Clear TDM_PDN to turn on TDM mode; Use ASP_SCLK_INV = 0
+		 * with SHIFT_LEFT = 1 combination as Figure 4-13 shows in
+		 * the CS53L30 datasheet
+		 */
+		aspctl1 |= CS53L30_SHIFT_LEFT;
 		break;
 	default:
 		return -EINVAL;
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] ASoC: cs53l30: Fix bit shift issue of TDM mode Nicolin Chen <nicoleotsuka@gmail.com> - 2016-07-20 00:40 +0200
  Applied "ASoC: cs53l30: Fix bit shift issue of TDM mode" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-07-21 13:10 +0200

csiph-web