Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1446698

Re: [PATCH] ACPI / PMIC: remove modular references from non-modular code

Show all headers | View raw

On Monday, July 11, 2016 06:05:16 PM Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of these files are:
> 
> drivers/acpi/Kconfig:menuconfig PMIC_OPREGION
> drivers/acpi/Kconfig:   bool "PMIC (Power Management Integrated Circuit) operation region support"
> 
> drivers/acpi/Kconfig:config BXT_WC_PMIC_OPREGION
> drivers/acpi/Kconfig:   bool "ACPI operation region support for BXT WhiskeyCove PMIC"
> 
> drivers/acpi/Kconfig:config XPOWER_PMIC_OPREGION
> drivers/acpi/Kconfig:   bool "ACPI operation region support for XPower AXP288 PMIC"
> 
> ...meaning they currently are not being built as a module by anyone.
> 
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the code there is no doubt it is builtin-only.
> 
> We delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> 
> One file was using module_init.  Since module_init translates to
> device_initcall in the non-modular case, the init ordering remains
> unchanged with this commit.
> 
> In one case we replace the module.h with export.h since that file
> is exporting some symbols, but does not use __init.  The other two
> are using __init and so module.h gets replaced with init.h there.
> 
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Len Brown <lenb@kernel.org>
> Cc: linux-acpi@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Applied, thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ACPI / PMIC: remove modular references from non-modular code Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-12 00:10 +0200
  Re: [PATCH] ACPI / PMIC: remove modular references from non-modular code "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-19 22:10 +0200

csiph-web