Re: [PATCH 02/14] resource limits: aggregate task highwater marks to cgroup level

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/14] resource limits: aggregate task highwater marks to cgroup level
Date	2016-07-19 20:20 +0200
Message-ID	<rWHMC-7oq-25@gated-at.bofh.it> (permalink)
References	(1 earlier) <rV8Hg-5Li-29@gated-at.bofh.it> <rVc89-7Vx-13@gated-at.bofh.it> <rVeWl-1cu-3@gated-at.bofh.it> <rWpG1-3Y1-3@gated-at.bofh.it> <rWGxc-6sA-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello, Topi.

On Tue, Jul 19, 2016 at 04:57:10PM +0000, Topi Miettinen wrote:
> Then there would need to be new limit checks at cgroup level. Would you
> see problems with that approach?

I'm worried that you're rushing this feature without thinking through
it.  You were mixing up completely orthogonal planes of accounting and
control without too much thought and are now suggesting something
which is also strange.  What do you mean by "new limit checks at
cgroup level"?  How would this be different from the resource
accounting and control implemented in the existing controllers?

Please take a step back and think through the overall design before
proposing changes to userland visible interface.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 02/14] resource limits: aggregate task highwater marks to cgroup level Topi Miettinen <toiwoton@gmail.com> - 2016-07-15 12:40 +0200
  Re: [PATCH 02/14] resource limits: aggregate task highwater marks to  cgroup level kbuild test robot <lkp@intel.com> - 2016-07-15 14:40 +0200
  Re: [PATCH 02/14] resource limits: aggregate task highwater marks to  cgroup level Tejun Heo <tj@kernel.org> - 2016-07-15 16:20 +0200
    Re: [PATCH 02/14] resource limits: aggregate task highwater marks to  cgroup level Topi Miettinen <toiwoton@gmail.com> - 2016-07-15 19:20 +0200
      Re: [PATCH 02/14] resource limits: aggregate task highwater marks to  cgroup level Tejun Heo <tj@kernel.org> - 2016-07-19 01:00 +0200
        Re: [PATCH 02/14] resource limits: aggregate task highwater marks to  cgroup level Topi Miettinen <toiwoton@gmail.com> - 2016-07-19 19:00 +0200
          Re: [PATCH 02/14] resource limits: aggregate task highwater marks to  cgroup level Tejun Heo <tj@kernel.org> - 2016-07-19 20:20 +0200

csiph-web