Re: [PATCH 3/3] staging/rtl8192u: use s8 instead of char

From	Jes Sorensen <Jes.Sorensen@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] staging/rtl8192u: use s8 instead of char
Date	2016-07-19 17:50 +0200
Message-ID	<rWFrr-5Qf-7@gated-at.bofh.it> (permalink)
References	<rWFhM-5LH-11@gated-at.bofh.it> <rWFhM-5LH-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Arnd Bergmann <arnd@arndb.de> writes:
> Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of
> incorrect code that results from 'char' being unsigned here, e.g.
>
> staging/rtl8192u/r8192U_core.c:4150:16: error: comparison is always false due to limited range of data type [-Werror=type-limits]
> staging/rtl8192u/r8192U_dm.c:646:50: error: comparison is always false due to limited range of data type [-Werror=type-limits]
>
> This patch changes all uses of 'char' in this driver that refer to
> 8-bit integers to use 's8' instead, which is signed on all architectures.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211.h |  4 ++--
>  drivers/staging/rtl8192u/r8192U.h              |  4 ++--
>  drivers/staging/rtl8192u/r8192U_core.c         | 14 +++++++-------
>  3 files changed, 11 insertions(+), 11 deletions(-)

Looks good to me

Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] staging/rtl8192u: use s8 instead of char Arnd Bergmann <arnd@arndb.de> - 2016-07-19 17:40 +0200
  Re: [PATCH 3/3] staging/rtl8192u: use s8 instead of char Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-07-19 17:50 +0200

csiph-web