Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1446578

[RFC 4/7] [media] rc-ir-raw: do not generate any receiving thread for raw transmitters

From Andi Shyti <andi.shyti@samsung.com>
Newsgroups linux.kernel
Subject [RFC 4/7] [media] rc-ir-raw: do not generate any receiving thread for raw transmitters
Date 2016-07-19 18:00 +0200
Message-ID <rWFB9-5U4-43@gated-at.bofh.it> (permalink)
References <rWFB7-5U4-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Raw IR transmitters do not need any thread listening for
occurring events. Check the driver type before running the
thread.

Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
---
 drivers/media/rc/rc-ir-raw.c | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/drivers/media/rc/rc-ir-raw.c b/drivers/media/rc/rc-ir-raw.c
index 144304c..64ddc3d 100644
--- a/drivers/media/rc/rc-ir-raw.c
+++ b/drivers/media/rc/rc-ir-raw.c
@@ -274,12 +274,19 @@ int ir_raw_event_register(struct rc_dev *dev)
 	INIT_KFIFO(dev->raw->kfifo);
 
 	spin_lock_init(&dev->raw->lock);
-	dev->raw->thread = kthread_run(ir_raw_event_thread, dev->raw,
-				       "rc%u", dev->minor);
 
-	if (IS_ERR(dev->raw->thread)) {
-		rc = PTR_ERR(dev->raw->thread);
-		goto out;
+	/*
+	 * raw transmitters do not need any event registration
+	 * because the event is coming from userspace
+	 */
+	if (dev->driver_type != RC_DRIVER_IR_RAW_TX) {
+		dev->raw->thread = kthread_run(ir_raw_event_thread, dev->raw,
+					       "rc%u", dev->minor);
+
+		if (IS_ERR(dev->raw->thread)) {
+			rc = PTR_ERR(dev->raw->thread);
+			goto out;
+		}
 	}
 
 	mutex_lock(&ir_raw_handler_lock);
-- 
2.8.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC 0/7] Add support for IR transmitters Andi Shyti <andi.shyti@samsung.com> - 2016-07-19 18:00 +0200
  [RFC 2/7] [media] rc-main: split setup and unregister functions Andi Shyti <andi.shyti@samsung.com> - 2016-07-19 18:00 +0200
  [RFC 4/7] [media] rc-ir-raw: do not generate any receiving thread for  raw transmitters Andi Shyti <andi.shyti@samsung.com> - 2016-07-19 18:00 +0200
  [RFC 3/7] [media] rc-core: add support for IR raw transmitters Andi Shyti <andi.shyti@samsung.com> - 2016-07-19 18:00 +0200
    Re: [RFC 3/7] [media] rc-core: add support for IR raw transmitters Sean Young <sean@mess.org> - 2016-07-20 00:20 +0200
      Re: [RFC 3/7] [media] rc-core: add support for IR raw transmitters Andi Shyti <andi.shyti@samsung.com> - 2016-07-21 02:50 +0200

csiph-web