Re: [PATCH v2 1/2] rtc: s3c: Remove unnecessary call to disable already disabled clock

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] rtc: s3c: Remove unnecessary call to disable already disabled clock
Date	2016-07-19 18:00 +0200
Message-ID	<rWFB7-5U4-3@gated-at.bofh.it> (permalink)
References	<rRvj3-16J-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/07/2016 at 15:28:52 +0530, Alim Akhtar wrote :
> At the end of s3c_rtc_probe(), s3c_rtc_disable_clk() being called with rtc
> clock already disabled (by s3c_rtc_gettime()), which looks extra and
> unnecessary call. Lets clean it up.
> 
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reviewed-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Tested-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
>  drivers/rtc/rtc-s3c.c |    2 --
>  1 file changed, 2 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/2] rtc: s3c: Remove unnecessary call to disable  already disabled clock Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-19 18:00 +0200

csiph-web