Re: [PATCH 13/32] Documentation, x86: Documentation for Intel resource allocation user interface

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 13/32] Documentation, x86: Documentation for Intel resource allocation user interface
Date	2016-07-19 14:40 +0200
Message-ID	<rWCtA-40N-17@gated-at.bofh.it> (permalink)
References	(1 earlier) <rUe2o-2xx-83@gated-at.bofh.it> <rUrVD-3bS-3@gated-at.bofh.it> <rUvZg-63d-29@gated-at.bofh.it> <rUIMN-64Y-1@gated-at.bofh.it> <rUSsO-45I-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 14 Jul 2016, Luck, Tony wrote:
> So the core part of __intel_rdt_sched_in() will look like:
> 
> 	/*
> 	 * Precedence rules:
> 	 * Processes assigned to an rdtgroup use that group
> 	 * wherever they run. If they don't have an rdtgroup
> 	 * we see if the current cpu has one and use it.
> 	 * If no specific rdtgroup was provided, we use the
> 	 * root_rdtgroup
> 	 */
> 	rdtgrp = current->rdtgroup;
> 	if (!rdtgrp) {
> 		rdtgrp = per_cpu(cpu_rdtgroup, cpu);
> 		if (!rdtgrp)
> 			rdtgrp = root_rdtgroup;
> 	}

That can be done simpler. The default cpu_rdtgroup should be root_rdtgroup. So
you spare one conditional.

Thanks

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 13/32] Documentation, x86: Documentation for Intel resource allocation user interface "Fenghua Yu" <fenghua.yu@intel.com> - 2016-07-13 00:10 +0200
  Re: [PATCH 13/32] Documentation, x86: Documentation for Intel resource  allocation user interface Thomas Gleixner <tglx@linutronix.de> - 2016-07-13 15:00 +0200
    Re: [PATCH 13/32] Documentation, x86: Documentation for Intel  resource allocation user interface "Luck, Tony" <tony.luck@intel.com> - 2016-07-13 19:20 +0200
      Re: [PATCH 13/32] Documentation, x86: Documentation for Intel resource  allocation user interface Thomas Gleixner <tglx@linutronix.de> - 2016-07-14 09:00 +0200
        Re: [PATCH 13/32] Documentation, x86: Documentation for Intel  resource allocation user interface "Luck, Tony" <tony.luck@intel.com> - 2016-07-14 19:20 +0200
          Re: [PATCH 13/32] Documentation, x86: Documentation for Intel resource  allocation user interface Thomas Gleixner <tglx@linutronix.de> - 2016-07-19 14:40 +0200

csiph-web