Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1446314

Re: [PATCH v2 3/3] acpi spi: Initialize modalias from of_compatible

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Jul 13, 2016 at 02:53:42PM +0300, Crestez Dan Leonard wrote:
> When using devicetree spi_device.modalias is set to the compatible
> string with the vendor prefix removed. For SPI devices described via
> ACPI the i2c_board_info.type string is initialized by acpi_device_hid.
> When using ACPI and DT ids this string ends up something like "PRP0001".

Please submit patches using subject lines reflecting the style for the
subsystem.  This makes it easier for people to identify relevant
patches.  Look at what existing commits in the area you're changing are
doing and make sure your subject lines visually resemble what they're
doing.

> Change acpi_register_spi_device to use the of_compatible property if
> present. This makes it easier to instantiate spi drivers through ACPI
> with DT ids.

This is basically fine but...

> +	if (adev->data.of_compatible) {
> +		ret = acpi_of_modalias(adev, spi->modalias, sizeof(spi->modalias));
> +		if (ret) {
> +			spi_dev_put(spi);
> +			return AE_NOT_FOUND;
> +		}

The only reason this could fail currently is that there wasn't a
compatible in the first place so why don't we just handle it like the no
compatible case?  It's probably not realistic but it seems like there's
a small chance this could regress some platform if we do add more error
detection in acpi_of_modalias().

I'm still not sure why if we want to translate ACPI into DT why we don't
actually translate and avoid all this special casing and churn.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] Init device ids from ACPI of_compatible Crestez Dan Leonard <leonard.crestez@intel.com> - 2016-07-13 14:00 +0200
  [PATCH v2 2/3] acpi i2c: Initialize info.type from of_compatible Crestez Dan Leonard <leonard.crestez@intel.com> - 2016-07-13 14:00 +0200
    Re: [PATCH v2 2/3] acpi i2c: Initialize info.type from of_compatible "Rafael J. Wysocki" <rafael@kernel.org> - 2016-07-13 14:30 +0200
      Re: [PATCH v2 2/3] acpi i2c: Initialize info.type from of_compatible Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-07-19 09:10 +0200
  [PATCH v2 3/3] acpi spi: Initialize modalias from of_compatible Crestez Dan Leonard <leonard.crestez@intel.com> - 2016-07-13 14:00 +0200
    Re: [PATCH v2 3/3] acpi spi: Initialize modalias from of_compatible "Rafael J. Wysocki" <rafael@kernel.org> - 2016-07-13 14:30 +0200
      Re: [PATCH v2 3/3] acpi spi: Initialize modalias from of_compatible Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-07-19 09:10 +0200
    Re: [PATCH v2 3/3] acpi spi: Initialize modalias from of_compatible Mark Brown <broonie@kernel.org> - 2016-07-19 12:30 +0200
      Re: [PATCH v2 3/3] acpi spi: Initialize modalias from of_compatible Crestez Dan Leonard <leonard.crestez@intel.com> - 2016-07-20 13:30 +0200
        Re: [PATCH v2 3/3] acpi spi: Initialize modalias from of_compatible Mark Brown <broonie@kernel.org> - 2016-07-20 13:40 +0200
  [PATCH v2 1/3] acpi: Export acpi_of_modalias equiv of of_modalias_node Crestez Dan Leonard <leonard.crestez@intel.com> - 2016-07-13 14:00 +0200
    Re: [PATCH v2 1/3] acpi: Export acpi_of_modalias equiv of of_modalias_node "Rafael J. Wysocki" <rafael@kernel.org> - 2016-07-13 14:30 +0200
    Re: [PATCH v2 1/3] acpi: Export acpi_of_modalias equiv of  of_modalias_node Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-07-19 09:20 +0200
  Re: [PATCH v2 0/3] Init device ids from ACPI of_compatible "Rafael J. Wysocki" <rafael@kernel.org> - 2016-07-13 14:20 +0200
  Re: [PATCH v2 0/3] Init device ids from ACPI of_compatible Dan O'Donovan <dan@emutex.com> - 2016-07-13 16:20 +0200

csiph-web