Re: [PATCH 01/10] Documentation: DT: qcom_hidma: update binding for MSI

From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/10] Documentation: DT: qcom_hidma: update binding for MSI
Date	2016-07-19 12:40 +0200
Message-ID	<rWABs-2Sv-19@gated-at.bofh.it> (permalink)
References	<rWlCq-1nW-35@gated-at.bofh.it> <rWlCq-1nW-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jul 18, 2016 at 02:39:28PM -0400, Sinan Kaya wrote:
> Adding a new binding for qcom,hidma-1.1 to distinguish HW supporting
> MSI interrupts from the older revision.
> 
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt
> index fd5618b..45ce75b 100644
> --- a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt
> +++ b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt
> @@ -47,7 +47,8 @@ When the OS is not in control of the management interface (i.e. it's a guest),
>  the channel nodes appear on their own, not under a management node.
>  
>  Required properties:
> -- compatible: must contain "qcom,hidma-1.0"
> +- compatible: must contain "qcom,hidma-1.0" for initial HW or "qcom,hidma-1.1"
> +for MSI capable HW.

Don't we need properties to describe the MSI details (e.g. sideband data
like DeviceID)?

Thanks,
Mark.

>  - reg: Addresses for the transfer and event channel
>  - interrupts: Should contain the event interrupt
>  - desc-count: Number of asynchronous requests this channel can handle
> -- 
> 1.8.2.1
>

Thread

[PATCH 01/10] Documentation: DT: qcom_hidma: update binding for MSI Sinan Kaya <okaya@codeaurora.org> - 2016-07-18 20:40 +0200
  Re: [PATCH 01/10] Documentation: DT: qcom_hidma: update binding for  MSI Mark Rutland <mark.rutland@arm.com> - 2016-07-19 12:40 +0200
    Re: [PATCH 01/10] Documentation: DT: qcom_hidma: update binding for  MSI Sinan Kaya <okaya@codeaurora.org> - 2016-07-19 14:50 +0200

csiph-web