Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

From	Peter Chen <hzpeterchen@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2] leds: trigger: Introduce an USB port trigger
Date	2016-07-18 07:50 +0200
Message-ID	<rW9Bf-291-1@gated-at.bofh.it> (permalink)
References	<rTIvv-6WO-1@gated-at.bofh.it> <rViGB-3uN-3@gated-at.bofh.it> <rW6Dn-jV-11@gated-at.bofh.it> <rW8Fb-1zz-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jul 18, 2016 at 06:44:49AM +0200, Rafał Miłecki wrote:
> On 18 July 2016 at 04:31, Peter Chen <hzpeterchen@gmail.com> wrote:
> > On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote:
> >> +
> >> +usbport trigger:
> >> +- usb-ports : List of USB ports that usbport should observed for turning on a
> >> +           given LED.
> >> +
> >
> > %s/should/should be
> 
> Thanks.
> 
> 
> >> diff --git a/drivers/leds/trigger/ledtrig-usbport.c b/drivers/leds/trigger/ledtrig-usbport.c
> >> new file mode 100644
> >> index 0000000..97b064c
> >> --- /dev/null
> >> +++ b/drivers/leds/trigger/ledtrig-usbport.c
> >> @@ -0,0 +1,206 @@
> >> +/*
> >> + * USB port LED trigger
> >> + *
> >> + * Copyright (C) 2016 Rafał Miłecki <rafal.milecki@gmail.com>
> >> + *
> >> + * This program is free software; you can redistribute it and/or modify
> >> + * it under the terms of the GNU General Public License as published by
> >> + * the Free Software Foundation; either version 2 of the License, or (at
> >> + * your option) any later version.
> >> + */
> >
> > GPL v2 only.
> >
> >> +MODULE_AUTHOR("Rafał Miłecki <rafal.milecki@gmail.com>");
> >> +MODULE_DESCRIPTION("USB port trigger");
> >> +MODULE_LICENSE("GPL");
> >
> > GPL v2
> 
> What's the reason for this? I don't have any real preference, but I
> never heard heard about kernel/Linux preference neither.
> 

https://en.wikipedia.org/wiki/Linux_kernel

-- 

Best Regards,
Peter Chen

Thread

[PATCH] leds: trigger: Introduce an USB port trigger Rafał Miłecki <zajec5@gmail.com> - 2016-07-11 14:30 +0200
  Re: [PATCH] leds: trigger: Introduce an USB port trigger Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-07-13 17:00 +0200
  [PATCH V2] leds: trigger: Introduce an USB port trigger Rafał Miłecki <zajec5@gmail.com> - 2016-07-15 23:20 +0200
    Re: [PATCH V2] leds: trigger: Introduce an USB port trigger Peter Chen <hzpeterchen@gmail.com> - 2016-07-18 04:40 +0200
      Re: [PATCH V2] leds: trigger: Introduce an USB port trigger Rafał Miłecki <zajec5@gmail.com> - 2016-07-18 06:50 +0200
        Re: [PATCH V2] leds: trigger: Introduce an USB port trigger Peter Chen <hzpeterchen@gmail.com> - 2016-07-18 07:50 +0200
          Re: [PATCH V2] leds: trigger: Introduce an USB port trigger Rafał Miłecki <zajec5@gmail.com> - 2016-07-18 08:00 +0200
            Re: [PATCH V2] leds: trigger: Introduce an USB port trigger Peter Chen <hzpeterchen@gmail.com> - 2016-07-18 08:10 +0200
              Re: [PATCH V2] leds: trigger: Introduce an USB port trigger Rafał Miłecki <zajec5@gmail.com> - 2016-07-18 09:00 +0200
                Re: [PATCH V2] leds: trigger: Introduce an USB port trigger Pavel Machek <pavel@ucw.cz> - 2016-07-20 10:10 +0200
      Re: [PATCH V2] leds: trigger: Introduce an USB port trigger Pavel Machek <pavel@ucw.cz> - 2016-07-20 10:10 +0200
    Re: [PATCH V2] leds: trigger: Introduce an USB port trigger Rob Herring <robh@kernel.org> - 2016-07-20 03:10 +0200
      Re: [PATCH V2] leds: trigger: Introduce an USB port trigger Rafał Miłecki <zajec5@gmail.com> - 2016-07-20 10:10 +0200
        Re: [PATCH V2] leds: trigger: Introduce an USB port trigger Rob Herring <robh@kernel.org> - 2016-07-21 22:50 +0200

csiph-web