Re: [PATCH 1/2] watchdog: ziirave_wdt: Correct I2C device id to fix module autoloading.

From	Wim Van Sebroeck <wim@iguana.be>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] watchdog: ziirave_wdt: Correct I2C device id to fix module autoloading.
Date	2016-07-17 22:10 +0200
Message-ID	<rW0xY-59Z-29@gated-at.bofh.it> (permalink)
References	<rKZFf-5tp-3@gated-at.bofh.it> <rKZFf-5tp-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Enric,

> The I2C core removes the manufacturer prefix from the compatible field
> so it reports to user-space the uevent i2c:rave-wdt, but this doesn't
> match with the i2c_device_id (i2c:ziirave-wdt) array so the module is not
> autoloaded. Correct the I2C device id to match with the reported uevent
> and fix the module autoloading functionality.
> 
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>  drivers/watchdog/ziirave_wdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/ziirave_wdt.c b/drivers/watchdog/ziirave_wdt.c
> index cbe373de..fa1efef 100644
> --- a/drivers/watchdog/ziirave_wdt.c
> +++ b/drivers/watchdog/ziirave_wdt.c
> @@ -339,7 +339,7 @@ static int ziirave_wdt_remove(struct i2c_client *client)
>  }
>  
>  static struct i2c_device_id ziirave_wdt_id[] = {
> -	{ "ziirave-wdt", 0 },
> +	{ "rave-wdt", 0 },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(i2c, ziirave_wdt_id);
> -- 
> 2.1.0
> 

This patch has been added to linux-watchdog-next.

Kind regards,
Wim.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] watchdog: ziirave_wdt: Correct I2C device id to fix module autoloading. Wim Van Sebroeck <wim@iguana.be> - 2016-07-17 22:10 +0200

csiph-web