Re: [PATCH] usb: gadget: uvc: Fix return value in case of error

From	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: gadget: uvc: Fix return value in case of error
Date	2016-07-16 14:40 +0200
Message-ID	<rVx2W-3O4-15@gated-at.bofh.it> (permalink)
References	<rVrTz-LE-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Christophe,

Thank you for the patch.

On Saturday 16 Jul 2016 09:04:40 Christophe JAILLET wrote:
> If this memory allocation fail, we will return 0, which means success.
> Return -ENOMEM instead.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/usb/gadget/function/uvc_configfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/function/uvc_configfs.c
> b/drivers/usb/gadget/function/uvc_configfs.c index 66753ba..31125a4 100644
> --- a/drivers/usb/gadget/function/uvc_configfs.c
> +++ b/drivers/usb/gadget/function/uvc_configfs.c
> @@ -2023,7 +2023,7 @@ static int uvcg_streaming_class_allow_link(struct
> config_item *src, if (!data) {
>  		kfree(*class_array);
>  		*class_array = NULL;
> -		ret = PTR_ERR(data);
> +		ret = -ENOMEM;
>  		goto unlock;
>  	}
>  	cl_arr = *class_array;

-- 
Regards,

Laurent Pinchart

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] usb: gadget: uvc: Fix return value in case of error Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-07-16 09:10 +0200
  Re: [PATCH] usb: gadget: uvc: Fix return value in case of error Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-07-16 14:40 +0200

csiph-web