Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1444762

[for-next][PATCH 5/7] tracing, RAS: Cleanup on __get_str() usage

Path csiph.com!goblin3!goblin1!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From Steven Rostedt <rostedt@goodmis.org>
Newsgroups linux.kernel
Subject [for-next][PATCH 5/7] tracing, RAS: Cleanup on __get_str() usage
Date Sat, 16 Jul 2016 09:20:01 +0200
Message-ID <rVs3f-OY-9@gated-at.bofh.it> (permalink)
References <rVs3f-OY-3@gated-at.bofh.it>
X-Original-To linux-kernel@vger.kernel.org
User-Agent quilt/0.61-1
MIME-Version 1.0
Content-Type text/plain; charset=ISO-8859-15
Content-Disposition inline; filename=0005-tracing-RAS-Cleanup-on-__get_str-usage.patch
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 44
Organization linux.* mail to news gateway
X-Original-Cc Ingo Molnar <mingo@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Trond Myklebust <trond.myklebust@primarydata.com>, Anna Schumaker <anna.schumaker@netapp.com>, Ingo Molnar <mingo@redhat.com>, Daniel Bristot de Oliveira <bristot@redhat.com>
X-Original-Date Sat, 16 Jul 2016 03:16:22 -0400
X-Original-Message-ID <20160716071647.493438712@goodmis.org>
X-Original-References <20160716071617.711980454@goodmis.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1444762

Show key headers only | View raw


From: Daniel Bristot de Oliveira <bristot@redhat.com>

__get_str(msg) does not need (char *) operator overloading to access
mgs's elements anymore. This patch substitutes
((char *)__get_str(msg))[0] usage to __get_str(msg)[0].

It is just a code cleanup, no changes on tracepoint ABI.

Link: http://lkml.kernel.org/r/6f2db5be7705da2cb483923320c91283d7c712a7.1467407618.git.bristot@redhat.com

Cc: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: Anna Schumaker <anna.schumaker@netapp.com>
Cc: Ingo Molnar <mingo@redhat.com>
Reviewed-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Daniel Bristot de Oliveira <bristot@redhat.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 include/ras/ras_event.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/ras/ras_event.h b/include/ras/ras_event.h
index 1443d79e4fe6..1791a12cfa85 100644
--- a/include/ras/ras_event.h
+++ b/include/ras/ras_event.h
@@ -147,7 +147,7 @@ TRACE_EVENT(mc_event,
 		  __entry->error_count,
 		  mc_event_error_type(__entry->error_type),
 		  __entry->error_count > 1 ? "s" : "",
-		  ((char *)__get_str(msg))[0] ? " " : "",
+		  __get_str(msg)[0] ? " " : "",
 		  __get_str(msg),
 		  __get_str(label),
 		  __entry->mc_index,
@@ -157,7 +157,7 @@ TRACE_EVENT(mc_event,
 		  __entry->address,
 		  1 << __entry->grain_bits,
 		  __entry->syndrome,
-		  ((char *)__get_str(driver_detail))[0] ? " " : "",
+		  __get_str(driver_detail)[0] ? " " : "",
 		  __get_str(driver_detail))
 );
 
-- 
2.8.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[for-next][PATCH 0/7] tracing: Some last updates for 4.8 Steven Rostedt <rostedt@goodmis.org> - 2016-07-16 09:20 +0200
  [for-next][PATCH 5/7] tracing, RAS: Cleanup on __get_str() usage Steven Rostedt <rostedt@goodmis.org> - 2016-07-16 09:20 +0200
  [for-next][PATCH 2/7] tracing: Have HIST_TRIGGERS select TRACING Steven Rostedt <rostedt@goodmis.org> - 2016-07-16 09:20 +0200
  [for-next][PATCH 4/7] tracing: Use outer () on __get_str() definition Steven Rostedt <rostedt@goodmis.org> - 2016-07-16 09:20 +0200
  [for-next][PATCH 7/7] printk, tracing: Avoiding unneeded blank lines Steven Rostedt <rostedt@goodmis.org> - 2016-07-16 09:20 +0200

csiph-web