Re: [PATCH V9 6/9] vfio: platform: call _RST method when using ACPI

From	Sinan Kaya <okaya@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V9 6/9] vfio: platform: call _RST method when using ACPI
Date	2016-07-16 03:10 +0200
Message-ID	<rVmhb-5I5-9@gated-at.bofh.it> (permalink)
References	<rUEg9-3ar-3@gated-at.bofh.it> <rUEg9-3ar-1@gated-at.bofh.it> <rUWZs-6XY-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 7/14/2016 6:04 PM, Alex Williamson wrote:
>> +static inline
>> > +bool vfio_platform_acpi_has_reset(struct vfio_platform_device *vdev)
>> > +{
>> > +#ifdef CONFIG_ACPI
>> > +	struct device *dev = vdev->device;
>> > +	acpi_handle handle = ACPI_HANDLE(dev);
>> > +
>> > +	return acpi_has_method(handle, "_RST");
>> > +#else
>> > +	return false;
>> > +#endif
>> > +}
> What exactly is the rationale for making these inline?  Clearly reset
> is not a performance relevant path.  Thanks,
> 
> Alex
> 

It is remaining from the previous stub functions which were inline. I'll get rid
of the inlines.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V9 6/9] vfio: platform: call _RST method when using ACPI Sinan Kaya <okaya@codeaurora.org> - 2016-07-14 04:10 +0200
  Re: [PATCH V9 6/9] vfio: platform: call _RST method when using ACPI Alex Williamson <alex.williamson@redhat.com> - 2016-07-15 00:10 +0200
    Re: [PATCH V9 6/9] vfio: platform: call _RST method when using ACPI Sinan Kaya <okaya@codeaurora.org> - 2016-07-16 03:10 +0200

csiph-web