Re: [PATCH 1/2] usb: typec: Add USB Power Delivery sink port support

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] usb: typec: Add USB Power Delivery sink port support
Date	2016-07-16 02:00 +0200
Message-ID	<rVlbs-4PI-9@gated-at.bofh.it> (permalink)
References	<rV0Tn-ZV-7@gated-at.bofh.it> <rV8Hg-5Li-39@gated-at.bofh.it> <rV9jX-6dN-7@gated-at.bofh.it> <rV9tE-6hc-35@gated-at.bofh.it> <rVjW2-4an-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jul 15, 2016 at 03:41:10PM -0700, Bin Gao wrote:
> On Fri, Jul 15, 2016 at 02:21:48PM +0300, Felipe Balbi wrote:
> > Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> > > On Fri, Jul 15, 2016 at 01:38:12PM +0300, Felipe Balbi wrote:
> > >> 
> > >> Hi,
> > >> 
> > >> Bin Gao <bin.gao@linux.intel.com> writes:
> > >> > +static void print_message(int port, bool is_cmsg, u8 msg, bool recv)
> > >> > +{
> > >> > +	pr_info("sink port %d: %s message %s %s\n", port,
> > >> > +				is_cmsg ? "Control" : "Data",
> > >> > +				msg_to_string(is_cmsg, msg),
> > >> > +		 recv ? "received" : "sent(wait GOODCRC)");
> > >> > +}
> > >> 
> > >> this is problematic. By default, we're all using 115200 8N1 baud
> > >> rate. This message alone prints anywhere from 50 to 100 characters (I
> > >> didn't really count properly, these are rough numbers), and that takes:
> > >> 
> > >> n50chars_time = 50 / (115200 / 10) = 4.3ms
> > >> n100chars_time = 100 / (115200 / 10) = 8.6ms
> > >> 
> > >> Considering you have 30ms to reply with Power Request after GoodCRC, and
> > >> considering you're printing several of these messages, they become
> > >> really expensive and eat up valuable time from tSenderReply.
> > >
> > > printk() should be async, so it shouldn't be that big of a deal.
> > 
> > I can actually see this causing problems ;-) With this pr_info(),
> > sometimes tSenderReply times out and Source gives a HardReset. Without
> > pr_info(), type-c analyzer tells me we reply in less than 1ms.
> > 
> > > What is wrong is that this isn't using dev_info().
> > 
> > right, that too.
> > 
> > -- 
> > balbi
> 
> When we don't have a struct device pointer for this driver,

Then you should fix that, as this is a driver for hardware :)

thanks,

greg k-h

Thread

Re: [PATCH 1/2] usb: typec: Add USB Power Delivery sink port support Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-07-15 12:40 +0200
  Re: [PATCH 1/2] usb: typec: Add USB Power Delivery sink port support Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-07-15 13:20 +0200
    Re: [PATCH 1/2] usb: typec: Add USB Power Delivery sink port support Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-07-15 13:30 +0200
      Re: [PATCH 1/2] usb: typec: Add USB Power Delivery sink port support Bin Gao <bin.gao@linux.intel.com> - 2016-07-16 00:40 +0200
        Re: [PATCH 1/2] usb: typec: Add USB Power Delivery sink port support Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-07-16 02:00 +0200
          Re: [PATCH 1/2] usb: typec: Add USB Power Delivery sink port support Bin Gao <bin.gao@linux.intel.com> - 2016-07-19 07:30 +0200
            Re: [PATCH 1/2] usb: typec: Add USB Power Delivery sink port support Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-07-19 10:40 +0200

csiph-web