Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1444682
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] net: ethernet: ti: cpmac: use phy_ethtool_{get|set}_link_ksettings |
| Date | 2016-07-16 01:50 +0200 |
| Message-ID | <rVl1M-4Mo-33@gated-at.bofh.it> (permalink) |
| References | <rV8Hg-5Li-25@gated-at.bofh.it> <rV8Hg-5Li-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Philippe Reynes <tremyfr@gmail.com>
Date: Fri, 15 Jul 2016 12:39:02 +0200
> There are two generics functions phy_ethtool_{get|set}_link_ksettings,
> so we can use them instead of defining the same code in the driver.
>
> There was a check on CAP_NET_ADMIN in cpmac_set_settings, but this
> check is already done in dev_ethtool, so no need to repeat it before
> calling the generic function.
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
Applied.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 2/2] net: ethernet: ti: cpmac: use phy_ethtool_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2016-07-15 12:40 +0200
Re: [PATCH 2/2] net: ethernet: ti: cpmac: use phy_ethtool_{get|set}_link_ksettings David Miller <davem@davemloft.net> - 2016-07-16 01:50 +0200
csiph-web